mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-09-06 19:38:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

perf(lsp): avoid repeated table lookup in completion.enable

Browse Source
This commit is contained in:
Mathias Fussenegger
2024-05-30 10:51:52 +02:00
committed by Mathias Fußenegger
parent 4c938f6d72
commit 138a93a057
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
runtime/lua/vim/lsp/completion.lua
View File

@@ -575,8 +575,10 @@ end
---@param bufnr integer ---@param bufnr integer
---@param opts vim.lsp.completion.BufferOpts ---@param opts vim.lsp.completion.BufferOpts
local function enable_completions(client_id, bufnr, opts) local function enable_completions(client_id, bufnr, opts)
if not buf_handles[bufnr] then local buf_handle = buf_handles[bufnr]
buf_handles[bufnr] = { clients = {}, triggers = {} } if not buf_handle then
buf_handle = { clients = {}, triggers = {} }
buf_handles[bufnr] = buf_handle
-- Attach to buffer events. -- Attach to buffer events.
api.nvim_buf_attach(bufnr, false, { api.nvim_buf_attach(bufnr, false, {
@@ -617,12 +619,12 @@ local function enable_completions(client_id, bufnr, opts)
end end
end end
if not buf_handles[bufnr].clients[client_id] then if not buf_handle.clients[client_id] then
local client = lsp.get_client_by_id(client_id) local client = lsp.get_client_by_id(client_id)
assert(client, 'invalid client ID') assert(client, 'invalid client ID')
-- Add the new client to the buffer's clients. -- Add the new client to the buffer's clients.
buf_handles[bufnr].clients[client_id] = client buf_handle.clients[client_id] = client
-- Add the new client to the clients that should be triggered by its trigger characters. -- Add the new client to the clients that should be triggered by its trigger characters.
--- @type string[] --- @type string[]
@@ -632,10 +634,10 @@ local function enable_completions(client_id, bufnr, opts)
'triggerCharacters' 'triggerCharacters'
) or {} ) or {}
for _, char in ipairs(triggers) do for _, char in ipairs(triggers) do
local clients_for_trigger = buf_handles[bufnr].triggers[char] local clients_for_trigger = buf_handle.triggers[char]
if not clients_for_trigger then if not clients_for_trigger then
clients_for_trigger = {} clients_for_trigger = {}
buf_handles[bufnr].triggers[char] = clients_for_trigger buf_handle.triggers[char] = clients_for_trigger
end end
local client_exists = vim.iter(clients_for_trigger):any(function(c) local client_exists = vim.iter(clients_for_trigger):any(function(c)
return c.id == client_id return c.id == client_id