vim-patch:7.4.1780 (#5828)

Problem:    Warnings reported by cppcheck.
Solution:   Fix the warnings. (Dominique Pelle)

dc633cf827

src/nvim/misc1.c

@@ -566,7 +566,7 @@ open_line (
             int i;
             int l;
 
-            for (i = 0; p[i] != NUL && i < lead_len; i += l) {
+            for (i = 0; i < lead_len && p[i] != NUL; i += l) {
               l = (*mb_ptr2len)(p + i);
               if (vim_strnsize(p, i + l) > repl_size)
                 break;

src/nvim/ops.c

@@ -4607,7 +4607,7 @@ int do_addsub(int op_type, pos_T *pos, int length, linenr_T Prenum1)
       goto theend;
     }
     ptr = buf1;
-    if (negative && (!visual || (visual && was_positive))) {
+    if (negative && (!visual || was_positive)) {
       *ptr++ = '-';
     }
     if (pre) {

src/nvim/version.c

@@ -660,7 +660,7 @@ static int included_patches[] = {
   // 1783,
   1782,
   // 1781,
-  // 1780,
+  1780,
   1779,
   // 1778 NA
   // 1777 NA