mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2026-05-01 19:45:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(api): return "style" in nvim_win_get_config() #38122

Browse Source 
Problem: nvim_win_get_config() does not return a window's "style".

Solution: always include it, and document `style=""`.

Always included so it can be used reciprocally with nvim_open_win() or
nvim_win_set_config(). (otherwise the config of a window with kWinStyleUnused
will not unset the kWinStyleMinimal style of another window if passed to
nvim_win_set_config, for example)
This commit is contained in:
Sean Dewar
2026-03-03 12:17:20 +00:00
committed by GitHub
parent 84d84e9b5b
commit 1901832f26
7 changed files with 76 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/nvim/api/keysets_defs.h
View File

@@ -126,7 +126,7 @@ typedef struct {
Boolean mouse;
Enum("cursor", "editor", "laststatus", "mouse", "tabline", "win") relative;
Float row;
Enum("minimal") style;
Enum("", "minimal") style;
Boolean noautocmd;
Boolean vertical;
Window win;

8
src/nvim/api/win_config.c
View File

@@ -163,8 +163,8 @@
/// - "win" Window given by the `win` field, or current window.
/// - row: Row position in units of "screen cell height", may be fractional.
/// - split: Split direction: "left", "right", "above", "below".
/// - style: (optional) Configure the appearance of the window. Currently
/// only supports one value:
/// - style: (optional) Configure the appearance of the window:
/// - "" No special style.
/// - "minimal" Nvim will display the window with many UI options
/// disabled. This is useful when displaying a temporary
/// float where the text should not be edited. Disables
@@ -728,6 +728,9 @@ Dict(win_config) nvim_win_get_config(Window window, Arena *arena, Error *err)
/// Keep in sync with WinSplit in buffer_defs.h
static const char *const win_split_str[] = { "left", "right", "above", "below" };
/// Keep in sync with WinStyle in buffer_defs.h
static const char *const win_style_str[] = { "", "minimal" };
Dict(win_config) rv = KEYDICT_INIT;
win_T *wp = find_window_by_handle(window, err);
@@ -741,6 +744,7 @@ Dict(win_config) nvim_win_get_config(Window window, Arena *arena, Error *err)
PUT_KEY_X(rv, external, config->external);
PUT_KEY_X(rv, hide, config->hide);
PUT_KEY_X(rv, mouse, config->mouse);
PUT_KEY_X(rv, style, cstr_as_string(win_style_str[config->style]));
if (wp->w_floating) {
PUT_KEY_X(rv, width, config->width);