mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-10-26 12:27:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(api): don't set coladd of mark (#26648)

Browse Source
This commit is contained in:
zeertzjq
2023-12-19 08:01:05 +08:00
committed by GitHub
parent 80f75d063d
commit 1cf51a07a6
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/nvim/api/private/helpers.c
View File

@@ -1044,7 +1044,7 @@ bool set_mark(buf_T *buf, String name, Integer line, Integer col, Error *err)
} }
} }
assert(INT32_MIN <= line && line <= INT32_MAX); assert(INT32_MIN <= line && line <= INT32_MAX);
pos_T pos = { (linenr_T)line, (int)col, (int)col }; pos_T pos = { (linenr_T)line, (int)col, 0 };
res = setmark_pos(*name.data, &pos, buf->handle, NULL); res = setmark_pos(*name.data, &pos, buf->handle, NULL);
if (!res) { if (!res) {
if (deleting) { if (deleting) {

6
test/functional/api/buffer_spec.lua
View File

@@ -1990,11 +1990,13 @@ describe('api/buf', function()
curbufmeths.set_lines(-1, -1, true, {'a', 'bit of', 'text'}) curbufmeths.set_lines(-1, -1, true, {'a', 'bit of', 'text'})
eq(true, curbufmeths.set_mark('z', 1, 1, {})) eq(true, curbufmeths.set_mark('z', 1, 1, {}))
eq({1, 1}, curbufmeths.get_mark('z')) eq({1, 1}, curbufmeths.get_mark('z'))
eq({0, 1, 2, 0}, funcs.getpos("'z"))
end) end)
it('works with file/uppercase marks', function() it('works with file/uppercase marks', function()
curbufmeths.set_lines(-1, -1, true, {'a', 'bit of', 'text'}) curbufmeths.set_lines(-1, -1, true, {'a', 'bit of', 'text'})
eq(true, curbufmeths.set_mark('Z', 3, 1, {})) eq(true, curbufmeths.set_mark('Z', 3, 2, {}))
eq({3, 1}, curbufmeths.get_mark('Z')) eq({3, 2}, curbufmeths.get_mark('Z'))
eq({curbuf().id, 3, 3, 0}, funcs.getpos("'Z"))
end) end)
it('fails when invalid marks names are used', function() it('fails when invalid marks names are used', function()
eq(false, pcall(curbufmeths.set_mark, '!', 1, 0, {})) eq(false, pcall(curbufmeths.set_mark, '!', 1, 0, {}))