mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2026-05-28 07:45:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(lsp): send didClose, didOpen when languageId changes #39499

Browse Source 
Problem:
If a buffer's filetype changes after the LSP client has already
attached (e.g. from json to jsonc via a modeline), but the client
supports both filetypes, it stays attached. It does not notify the
server of the new languageId, causing the server to incorrectly process
the file using the old languageId.

Solution:
Save the languageId used during textDocument/didOpen, and send
textDocument/didClose + textDocument/didOpen when buffer's languageId
changed.

Lsp spec:
0003fb53f1/_specifications/lsp/3.18/textDocument/didOpen.md (L5)
> If the language id of a document changes, the client
> needs to send a textDocument/didClose to the server followed by a
> textDocument/didOpen with the new language id if the server handles
> the new language id as well.

AI-assisted: Gemini 3.1 Pro
This commit is contained in:
phanium
2026-04-30 17:56:16 +08:00
committed by GitHub
parent 1e06e95662
commit 1e7edb2c52
5 changed files with 79 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
runtime/lua/vim/lsp.lua
View File

@@ -531,9 +531,20 @@ local function lsp_enable_callback(bufnr)
lsp.is_enabled(client.name)
-- Check that the client is managed by vim.lsp.config before deciding to detach it!
and lsp.config[client.name]
and not can_start(bufnr, lsp.config[client.name], false)
then
lsp.buf_detach_client(bufnr, client.id)
if can_start(bufnr, lsp.config[client.name], false) then
-- When switch between lsp supported filetype (e.g. json to jsonc like #39498),
-- client should send `textDocument/didClose` + `textDocument/didOpen` with new language id
local new_language_id = client.get_language_id(bufnr, vim.bo[bufnr].filetype)
local old_language_id = client.attached_buffers[bufnr] ---@type string?
if old_language_id and old_language_id ~= new_language_id then
client:_text_document_did_close_handler(bufnr)
client.attached_buffers[bufnr] = new_language_id
client:_text_document_did_open_handler(bufnr)
end
else
lsp.buf_detach_client(bufnr, client.id)
end
end
end
@@ -1002,7 +1013,7 @@ function lsp.buf_attach_client(bufnr, client_id)
return true
end
client.attached_buffers[bufnr] = true
client.attached_buffers[bufnr] = client.get_language_id(bufnr, vim.bo[bufnr].filetype)
-- This is our first time attaching this client to this buffer.
-- Send didOpen for the client if it is initialized. If it isn't initialized