mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-09-18 01:08:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(fileio_spec): unreliable fsync test

Browse Source 
Problem:
CI sometimes fails. Something is triggering an extra fsync().

    FAILED   test/functional/core/fileio_spec.lua @ 52: fileio fsync() codepaths #8304
    test/functional/core/fileio_spec.lua:87: Expected objects to be the same.
    Passed in:
    (number) 3
    Expected:
    (number) 2
    stack traceback:
            test/functional/core/fileio_spec.lua:87: in function <test/functional/core/fileio_spec.lua:52>

Solution:
Relax the assertion to `fsync >= 2` instead of exactly 2.

(Note this is not a behavior change: the next assertion has always
checked `fsync == 4`, it's just that the intermediate 3rd fsync was
never explicitly asserted.)
This commit is contained in:
Justin M. Keyes
2023-12-05 13:52:51 +01:00
parent 1457272726
commit 1fd29a2884
3 changed files with 26 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
test/functional/core/fileio_spec.lua
View File

@@ -49,48 +49,48 @@ describe('fileio', function()
rmdir('Xtest_backupdir with spaces')
end)
it('fsync() codepaths #8304', function()
clear({ args={ '-i', 'Xtest_startup_shada',
'--cmd', 'set nofsync',
'--cmd', 'set directory=Xtest_startup_swapdir' } })
it("fsync() with 'nofsync' #8304", function()
clear({ args={ '--cmd', 'set nofsync directory=Xtest_startup_swapdir', } })
-- These cases ALWAYS force fsync (regardless of 'fsync' option):
-- 1. Idle (CursorHold) with modified buffers (+ 'swapfile').
command('write Xtest_startup_file1')
feed('ifoo<esc>h')
feed('Afoo<esc>h')
command('write')
eq(0, request('nvim__stats').fsync) -- 'nofsync' is the default.
eq(0, request('nvim__stats').fsync)
command('set swapfile')
command('set updatetime=1')
feed('izub<esc>h') -- File is 'modified'.
feed('Azub<esc>h') -- File is 'modified'.
sleep(3) -- Allow 'updatetime' to expire.
retry(3, nil, function()
eq(1, request('nvim__stats').fsync)
end)
command('set updatetime=9999')
command('set updatetime=100000 updatecount=100000')
-- 2. Exit caused by deadly signal (+ 'swapfile').
local j = funcs.jobstart({ nvim_prog, '-u', 'NONE', '-i',
'Xtest_startup_shada', '--headless',
-- 2. Explicit :preserve command.
command('preserve')
-- TODO: should be exactly 2; figure out where the extra fsync() is coming from. #26404
ok(request('nvim__stats').fsync >= 2)
-- 3. Enable 'fsync' option, write file.
command('set fsync')
feed('Abaz<esc>h')
command('write')
eq(4, request('nvim__stats').fsync)
eq('foozubbaz', trim(read_file('Xtest_startup_file1')))
-- 4. Exit caused by deadly signal (+ 'swapfile').
local j = funcs.jobstart({ nvim_prog, '-u', 'NONE', '--headless',
'--cmd', 'set nofsync directory=Xtest_startup_swapdir',
'-c', 'set swapfile',
'-c', 'write Xtest_startup_file2',
'-c', 'put =localtime()', })
sleep(10) -- Let Nvim start.
funcs.jobstop(j) -- Send deadly signal.
-- 3. SIGPWR signal.
-- 5. SIGPWR signal.
-- ??
-- 4. Explicit :preserve command.
command('preserve')
eq(2, request('nvim__stats').fsync)
-- 5. Enable 'fsync' option, write file.
command('set fsync')
feed('ibaz<esc>h')
command('write')
eq(4, request('nvim__stats').fsync)
end)
it('backup #9709', function()