mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2026-03-31 04:42:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

vim-patch:9.2.0054: eval_addblob() is inefficient (#38067)

Browse Source 
Problem:  eval_addblob() is inefficient
Solution: Replace per-byte ga_append() loop with a single ga_grow() and
          mch_memmove() for each source blob.  This eliminates N grow
          checks and function call overhead for blob concatenation
          (Yasuhiro Matsumoto).

closes: vim/vim#19494

c389ae8c44

Omit the pointless int -> long changes in other functions.

Co-authored-by: Yasuhiro Matsumoto <mattn.jp@gmail.com>
This commit is contained in:
zeertzjq
2026-02-26 08:15:57 +08:00
committed by GitHub
parent 9288357d59
commit 1fe1b2525f
1 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/nvim/eval.c
View File

@@ -2233,11 +2233,19 @@ static void eval_addblob(typval_T *tv1, typval_T *tv2)
const blob_T *const b2 = tv2->vval.v_blob;
blob_T *const b = tv_blob_alloc();
for (int i = 0; i < tv_blob_len(b1); i++) {
ga_append(&b->bv_ga, tv_blob_get(b1, i));
}
for (int i = 0; i < tv_blob_len(b2); i++) {
ga_append(&b->bv_ga, tv_blob_get(b2, i));
int64_t len1 = tv_blob_len(b1);
int64_t len2 = tv_blob_len(b2);
int64_t totallen = len1 + len2;
if (totallen >= 0 && totallen <= INT_MAX) {
ga_grow(&b->bv_ga, (int)totallen);
if (len1 > 0) {
memmove((char *)b->bv_ga.ga_data, b1->bv_ga.ga_data, (size_t)len1);
}
if (len2 > 0) {
memmove((char *)b->bv_ga.ga_data + len1, b2->bv_ga.ga_data, (size_t)len2);
}
b->bv_ga.ga_len = (int)totallen;
}
tv_clear(tv1);