From 2450ae797c5adee90c267cf28baaab54eebf9796 Mon Sep 17 00:00:00 2001 From: Jan Edmund Lazo Date: Mon, 10 Aug 2026 00:29:42 -0400 Subject: [PATCH] build(vim-patch): sound feature is n/a (#41257) Vim core did not leverage it to override/customize bell/beep. It wasn't used for custom sounds for system/user (autocmd) events. It should be in-scope for GUI, unlike terminal, even as a plugin by leveraging some internal option similar to `set guioptions+=!`. No progress as of Vim 9.2 so I quit. --- scripts/vim-patch.sh | 6 +++--- scripts/vim_na_files.txt | 2 ++ scripts/vim_na_hunks_c.txt | 1 + scripts/vim_na_hunks_vim.txt | 2 ++ 4 files changed, 8 insertions(+), 3 deletions(-) diff --git a/scripts/vim-patch.sh b/scripts/vim-patch.sh index 7de6ea129e..867201d767 100755 --- a/scripts/vim-patch.sh +++ b/scripts/vim-patch.sh @@ -958,7 +958,7 @@ is_na_patch() { HUNKS=$(git -C "${VIM_SOURCE_DIR}" diff-tree --no-commit-id -r -b -U0 \ '-I^\s+$' \ '-I^\s*/?\*/?$' \ - '-I^\s*(//|/?\*).*\s[vV]im9' \ + '-I^\s*(//|/?\*).*\s([vV]im9|sound)' \ '-I^#\s*((ifdef|ifndef|define|undef)|(if|elif)\s.*defined\().*FEAT_' \ '-I^#\s*(else|endif)' \ '-I#\s*define\s+XDG_' \ @@ -987,11 +987,11 @@ is_na_patch() { HUNKS=$(git -C "${VIM_SOURCE_DIR}" diff-tree --no-commit-id -r -b -U0 \ '-I^\s+$' \ '-I^\s*/?\*/?$' \ - '-I^\s*(//|/?\*).*\s[vV]im9' \ + '-I^\s*(//|/?\*).*\s([vV]im9|sound)' \ '-I^#\s*((ifdef|ifndef|define|undef)\s|(if|elif)\s.*defined\().*FEAT_' \ '-I^#\s*(else|endif)' \ '-I^#\s*include\s+]sc_version = ' \ '-I[_.>]uf_script_ctx_version = ' \ diff --git a/scripts/vim_na_files.txt b/scripts/vim_na_files.txt index 566b85339f..c8edd47ce6 100644 --- a/scripts/vim_na_files.txt +++ b/scripts/vim_na_files.txt @@ -93,6 +93,7 @@ src/po/zh_CN.po src/po/zh_TW.po src/sixel.c src/socketserver.c +src/sound.c src/tabpanel.c src/terminal.c src/termlib.c @@ -130,6 +131,7 @@ src/testdir/test_remote.vim src/testdir/test_restricted.vim src/testdir/test_short_sleep.py src/testdir/test_shortpathname.vim +src/testdir/test_sound.vim src/testdir/test_suspend.vim src/testdir/test_tabpanel.vim src/testdir/test_tcl.vim diff --git a/scripts/vim_na_hunks_c.txt b/scripts/vim_na_hunks_c.txt index f342b49dff..299a7d18b4 100644 --- a/scripts/vim_na_hunks_c.txt +++ b/scripts/vim_na_hunks_c.txt @@ -48,6 +48,7 @@ ^mch_create_pty_channel( ^mch_job_[a-z]\+( ^mem_[a-zA-Z0-9_]\+( +^parse_queued_messages( ^restore_buffer(bufref_T ^static int included_patches\[\] = ^switch_buffer(bufref_T diff --git a/scripts/vim_na_hunks_vim.txt b/scripts/vim_na_hunks_vim.txt index b8243097d8..c98b140c44 100644 --- a/scripts/vim_na_hunks_vim.txt +++ b/scripts/vim_na_hunks_vim.txt @@ -98,6 +98,8 @@ \*help-toc-install\* \*os-support\* \*patches-\(after-\)\?[0-9].*\* +\*sound-functions\* +\*sound_[a-zA-Z0-9]\+()\* \*test_gui_[a-zA-Z0-9_]\+()\* \*v:none\* \*v:sizeof[a-z]\+\*