mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-12-11 17:12:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

job: Close libuv handles when uv_spawn fails

Browse Source 
Commit @709685b4612f4 removed the close_job_* calls when uv_spawn fails because
of memory errors when trying to cleanup unitialized {R,W}Stream instances, but
the uv_pipe_t instances must be closed because they are added to the event loop
queue by previous `uv_pipe_init()` calls
This commit is contained in:
Thiago de Arruda
2014-10-30 09:23:35 -03:00
parent a8656ed50a
commit 25e26e0056
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/nvim/os/job.c
View File

@@ -215,6 +215,10 @@ Job *job_start(char **argv,
// Spawn the job // Spawn the job
if (uv_spawn(uv_default_loop(), &job->proc, &job->proc_opts) != 0) { if (uv_spawn(uv_default_loop(), &job->proc, &job->proc_opts) != 0) {
uv_close((uv_handle_t *)&job->proc_stdin, NULL);
uv_close((uv_handle_t *)&job->proc_stdout, NULL);
uv_close((uv_handle_t *)&job->proc_stderr, NULL);
event_poll(0);
*status = -1; *status = -1;
return NULL; return NULL;
} }