mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-09-28 22:18:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

vim-patch:8.2.4723: the ModeChanged autocmd event is inefficient

Browse Source 
Problem:    The ModeChanged autocmd event is inefficient.
Solution:   Avoid allocating memory. (closes vim/vim#10134)  Rename
            trigger_modechanged() to may_trigger_modechanged().
2bf52dd065

Make v:event readonly for ModeChanged.
This commit is contained in:
zeertzjq
2022-04-10 07:20:35 +08:00
parent ff726cc569
commit 263a7fde35
12 changed files with 77 additions and 71 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/nvim/normal.c
View File

@@ -481,7 +481,7 @@ static void normal_prepare(NormalState *s)
if (finish_op != c) {
ui_cursor_shape(); // may show different cursor shape
}
trigger_modechanged();
may_trigger_modechanged();
// When not finishing an operator and no register name typed, reset the count.
if (!finish_op && !s->oa.regname) {
@@ -920,7 +920,7 @@ normal_end:
// Reset finish_op, in case it was set
s->c = finish_op;
finish_op = false;
trigger_modechanged();
may_trigger_modechanged();
// Redraw the cursor with another shape, if we were in Operator-pending
// mode or did a replace command.
if (s->c || s->ca.cmdchar == 'r') {
@@ -959,7 +959,7 @@ normal_end:
if (restart_VIsual_select == 1) {
VIsual_select = true;
VIsual_select_reg = 0;
trigger_modechanged();
may_trigger_modechanged();
showmode();
restart_VIsual_select = 0;
}
@@ -2299,7 +2299,7 @@ void end_visual_mode(void)
may_clear_cmdline();
adjust_cursor_eol();
trigger_modechanged();
may_trigger_modechanged();
}
/*
@@ -4113,7 +4113,7 @@ static void nv_ctrlg(cmdarg_T *cap)
{
if (VIsual_active) { // toggle Selection/Visual mode
VIsual_select = !VIsual_select;
trigger_modechanged();
may_trigger_modechanged();
showmode();
} else if (!checkclearop(cap->oap)) {
// print full name if count given or :cd used
@@ -4157,7 +4157,7 @@ static void nv_ctrlo(cmdarg_T *cap)
{
if (VIsual_active && VIsual_select) {
VIsual_select = false;
trigger_modechanged();
may_trigger_modechanged();
showmode();
restart_VIsual_select = 2; // restart Select mode later
} else {
@@ -5945,7 +5945,7 @@ static void nv_visual(cmdarg_T *cap)
// or char/line mode
VIsual_mode = cap->cmdchar;
showmode();
trigger_modechanged();
may_trigger_modechanged();
}
redraw_curbuf_later(INVERTED); // update the inversion
} else { // start Visual mode
@@ -6056,7 +6056,7 @@ static void n_start_visual_mode(int c)
foldAdjustVisual();
trigger_modechanged();
may_trigger_modechanged();
setmouse();
// Check for redraw after changing the state.
conceal_check_cursor_line();