From 26eb6785eb9615b84ca66676da10a8b4ed1c7f95 Mon Sep 17 00:00:00 2001 From: ii14 Date: Tue, 26 Apr 2022 16:57:52 +0200 Subject: [PATCH] fix(lsp): fix unnecessary buffers being added on empty diagnostics Some language servers send empty `textDocument/publishDiagnostics` messages after indexing the project, sometimes resulting in creation of a lot of unnecessary buffers. As a workaround, skip empty messages for nonexistent buffers before resolving the filename to a bufnr. --- runtime/lua/vim/lsp/diagnostic.lua | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/runtime/lua/vim/lsp/diagnostic.lua b/runtime/lua/vim/lsp/diagnostic.lua index 614d83f565..6a8d6dcad7 100644 --- a/runtime/lua/vim/lsp/diagnostic.lua +++ b/runtime/lua/vim/lsp/diagnostic.lua @@ -185,7 +185,12 @@ end function M.on_publish_diagnostics(_, result, ctx, config) local client_id = ctx.client_id local uri = result.uri - local bufnr = vim.uri_to_bufnr(uri) + local fname = vim.uri_to_fname(uri) + local diagnostics = result.diagnostics + if #diagnostics == 0 and vim.fn.bufexists(fname) == 0 then + return + end + local bufnr = vim.fn.bufadd(fname) if not bufnr then return @@ -193,7 +198,6 @@ function M.on_publish_diagnostics(_, result, ctx, config) client_id = get_client_id(client_id) local namespace = M.get_namespace(client_id) - local diagnostics = result.diagnostics if config then for _, opt in pairs(config) do