mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-10-05 09:26:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: fileio_spec is unreliable/flaky #26404

Browse Source 
Problem:
CI sometimes fails. Something is triggering an extra fsync().

    FAILED   test/functional/core/fileio_spec.lua @ 52: fileio fsync() codepaths #8304
    test/functional/core/fileio_spec.lua:87: Expected objects to be the same.
    Passed in:
    (number) 3
    Expected:
    (number) 2
    stack traceback:
            test/functional/core/fileio_spec.lua:87: in function <test/functional/core/fileio_spec.lua:52>

Solution:
Relax the assertion to `fsync >= 2` instead of exactly 2.

(Note this is not a behavior change: the next assertion has always
checked `fsync == 4`, it's just that the intermediate 3rd fsync was
never explicitly asserted.)
This commit is contained in:
Justin M. Keyes
2023-12-05 12:52:06 -08:00
committed by GitHub
parent ca4fe083e5
commit 27501d3b6a
3 changed files with 26 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/nvim/globals.h
View File

@@ -672,7 +672,7 @@ EXTERN bool must_redraw_pum INIT( = false); // redraw pum. NB: must_redraw
EXTERN bool need_highlight_changed INIT( = true);
EXTERN FILE *scriptout INIT( = NULL); ///< Stream to write script to.
EXTERN FILE *scriptout INIT( = NULL); ///< Write input to this file ("nvim -w").
// Note that even when handling SIGINT, volatile is not necessary because the
// callback is not called directly from the signal handlers.