mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2026-04-21 14:55:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

vim-patch:9.0.0025: accessing beyond allocated memory with the cmdline window

Browse Source 
Problem:    Accessing beyond allocated memory when using the cmdline window in
            Ex mode.
Solution:   Use "*" instead of "'<,'>" for Visual mode.

c6fdb15d42

Co-authored-by: Bram Moolenaar <Bram@vim.org>
This commit is contained in:
Jan Edmund Lazo
2025-12-13 01:11:25 -05:00
parent edd99f09c7
commit 2c560d8544
2 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/nvim/ex_docmd.c
View File

@@ -2777,9 +2777,11 @@ int parse_command_modifiers(exarg_T *eap, const char **errormsg, cmdmod_T *cmod,
size_t len = strlen(cmd_start); size_t len = strlen(cmd_start);
// Special case: empty command uses "+": // Special case: empty command uses "+":
// "'<,'>mods" -> "mods'<,'>+ // "'<,'>mods" -> "mods *+
// Use "*" instead of "'<,'>" to avoid the command getting
// longer, in case is was allocated.
memmove(orig_cmd, cmd_start, len); memmove(orig_cmd, cmd_start, len);
strcpy(orig_cmd + len, "'<,'>+"); xmemcpyz(orig_cmd + len, S_LEN(" *+"));
} else { } else {
memmove(cmd_start - 5, cmd_start, (size_t)(eap->cmd - cmd_start)); memmove(cmd_start - 5, cmd_start, (size_t)(eap->cmd - cmd_start));
eap->cmd -= 5; eap->cmd -= 5;

8
test/old/testdir/test_cmdline.vim
View File

@@ -2561,6 +2561,14 @@ func Test_cmdwin_insert_mode_close()
call assert_equal(1, winnr('$')) call assert_equal(1, winnr('$'))
endfunc endfunc
func Test_cmdwin_ex_mode_with_modifier()
" this was accessing memory after allocated text in Ex mode
new
call setline(1, ['some', 'text', 'lines'])
silent! call feedkeys("gQnormal vq:atopleft\<C-V>\<CR>\<CR>", 'xt')
bwipe!
endfunc
" test that ";" works to find a match at the start of the first line " test that ";" works to find a match at the start of the first line
func Test_zero_line_search() func Test_zero_line_search()
new new