mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2026-07-16 06:10:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(api): nvim_get_option_value tab-local 'cmdheight' #39259

Browse Source 
Problem:
API clients cannot query the tab-local value of 'cmdheight'.

Solution:
Allow nvim_get_option_value() to accept { tab = <tab-ID> } for 'cmdheight'.
This commit is contained in:
EliWiegman
2026-05-16 09:31:05 -04:00
committed by GitHub
parent b92ca58d69
commit 2d795face6
6 changed files with 120 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

46
test/functional/api/vim_spec.lua
View File

@@ -1952,6 +1952,52 @@ describe('API', function()
'Invalid value for option \'scrolloff\': expected number, got string "wrong"',
pcall_err(api.nvim_set_option_value, 'scrolloff', 'wrong', {})
)
local tab1 = api.nvim_get_current_tabpage()
eq(
"Conflict: 'tab' not allowed with 'win', 'buf', 'filetype' or 'scope'",
pcall_err(
api.nvim_get_option_value,
'cmdheight',
{ tab = tab1, win = api.nvim_get_current_win() }
)
)
eq(
"Conflict: 'tab' not allowed with 'win', 'buf', 'filetype' or 'scope'",
pcall_err(api.nvim_get_option_value, 'cmdheight', {
tab = tab1,
scope = 'local',
})
)
eq(
"'tab' can only be used with option 'cmdheight'",
pcall_err(api.nvim_get_option_value, 'shiftwidth', { tab = tab1 })
)
eq(
"Conflict: 'tab' not allowed with 'nvim_set_option_value'",
pcall_err(api.nvim_set_option_value, 'cmdheight', 2, { tab = tab1 })
)
eq(
"Conflict: 'tab' not allowed with 'nvim_get_option_info2'",
pcall_err(api.nvim_get_option_info2, 'cmdheight', { tab = tab1 })
)
eq(
"Conflict: 'filetype' not allowed with 'scope', 'buf', 'win' or 'tab'",
pcall_err(api.nvim_get_option_value, 'cmdheight', { filetype = 'c', tab = 0 })
)
end)
it("tabpage-local 'cmdheight' #31140", function()
api.nvim_set_option_value('cmdheight', 1, {})
local tab1 = api.nvim_get_current_tabpage()
eq(1, api.nvim_get_option_value('cmdheight', { tab = 0 }))
eq(1, api.nvim_get_option_value('cmdheight', { tab = tab1 }))
eq(1, api.nvim_get_option_value('cmdheight', {}))
command('tabnew')
local tab2 = api.nvim_get_current_tabpage()
api.nvim_set_option_value('cmdheight', 4, {})
eq(4, api.nvim_get_option_value('cmdheight', { tab = tab2 }))
eq(1, api.nvim_get_option_value('cmdheight', { tab = tab1 }))
eq(4, api.nvim_get_option_value('cmdheight', {}))
end)
it('can get local values when global value is set', function()