mirror of
https://github.com/neovim/neovim.git
synced 2025-09-17 16:58:17 +00:00
fix(lsp): misleading logs in non-applicable filetypes #35749
Problem: LSP logs show misleading "cannot start" messages when editing a filetype NOT listed in the `config.filetypes` field. [ERROR][2025-09-13 18:55:56] …/runtime//lua/vim/lsp/log.lua:151 "cannot start cssls due to config error: …/runtime//lua/vim/lsp.lua:423: cmd: expected expected function or table with executable command, got table: 0x0104701b18. Info: vscode-css-language-server is not executable" Solution: - `can_start`: check `config.filetypes` before checking the rest of the config.
This commit is contained in:
@@ -426,16 +426,21 @@ local function validate_config(config)
|
||||
end
|
||||
|
||||
--- @param bufnr integer
|
||||
--- @param name string
|
||||
--- @param config vim.lsp.Config
|
||||
local function can_start(bufnr, name, config)
|
||||
local config_ok, err = pcall(validate_config, config)
|
||||
if not config_ok then
|
||||
log.error(('cannot start %s due to config error: %s'):format(name, err))
|
||||
--- @param logging boolean
|
||||
local function can_start(bufnr, config, logging)
|
||||
if
|
||||
type(config.filetypes) == 'table'
|
||||
and not vim.tbl_contains(config.filetypes, vim.bo[bufnr].filetype)
|
||||
then
|
||||
return false
|
||||
end
|
||||
|
||||
if config.filetypes and not vim.tbl_contains(config.filetypes, vim.bo[bufnr].filetype) then
|
||||
local config_ok, err = pcall(validate_config, config)
|
||||
if not config_ok then
|
||||
if logging then
|
||||
log.error(('invalid "%s" config: %s'):format(config.name, err))
|
||||
end
|
||||
return false
|
||||
end
|
||||
|
||||
@@ -462,9 +467,7 @@ local function lsp_enable_callback(bufnr)
|
||||
-- Stop any clients that no longer apply to this buffer.
|
||||
local clients = lsp.get_clients({ bufnr = bufnr, _uninitialized = true })
|
||||
for _, client in ipairs(clients) do
|
||||
if
|
||||
lsp.is_enabled(client.name) and not can_start(bufnr, client.name, lsp.config[client.name])
|
||||
then
|
||||
if lsp.is_enabled(client.name) and not can_start(bufnr, lsp.config[client.name], false) then
|
||||
lsp.buf_detach_client(bufnr, client.id)
|
||||
end
|
||||
end
|
||||
@@ -472,7 +475,7 @@ local function lsp_enable_callback(bufnr)
|
||||
-- Start any clients that apply to this buffer.
|
||||
for name in vim.spairs(lsp._enabled_configs) do
|
||||
local config = lsp.config[name]
|
||||
if config and can_start(bufnr, name, config) then
|
||||
if config and can_start(bufnr, config, true) then
|
||||
-- Deepcopy config so changes done in the client
|
||||
-- do not propagate back to the enabled configs.
|
||||
config = vim.deepcopy(config)
|
||||
|
Reference in New Issue
Block a user