mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-12-16 19:35:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

win: nvim_get_proc_children()

Browse Source 
TODO: Raymond Chen explains[1] racy behavior of the
CreateToolhelp32Snapshot approach.  Better approach:

> create a job object and put process P in it. Then call
> QueryInformationJobObject with JobObjectBasicProcessIdList to get the
> list of child processes.

[1] "Why is CreateToolhelp32Snapshot returning incorrect parent process IDs all of a sudden?"
    https://blogs.msdn.microsoft.com/oldnewthing/20150403-00/?p=44313
This commit is contained in:
Justin M. Keyes
2018-03-15 02:33:20 +01:00
parent 12af7016e2
commit 330e5acbce
1 changed files with 30 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
src/nvim/os/process.c
View File

@@ -43,7 +43,6 @@ static bool os_proc_tree_kill_rec(HANDLE process, int sig)
if (!Process32First(h, &pe)) { if (!Process32First(h, &pe)) {
goto theend; goto theend;
} }
do { do {
if (pe.th32ParentProcessID == pid) { if (pe.th32ParentProcessID == pid) {
HANDLE ph = OpenProcess(PROCESS_ALL_ACCESS, false, pe.th32ProcessID); HANDLE ph = OpenProcess(PROCESS_ALL_ACCESS, false, pe.th32ProcessID);
@@ -53,7 +52,6 @@ static bool os_proc_tree_kill_rec(HANDLE process, int sig)
} }
} }
} while (Process32Next(h, &pe)); } while (Process32Next(h, &pe));
CloseHandle(h); CloseHandle(h);
} }
} }
@@ -111,11 +109,40 @@ int os_proc_children(int ppid, int **proc_list, size_t *proc_count)
// https://github.com/giampaolo/psutil/tree/master/psutil/arch // https://github.com/giampaolo/psutil/tree/master/psutil/arch
// //
if (ppid < 0) {
return 2;
}
int *temp = NULL; int *temp = NULL;
*proc_list = NULL; *proc_list = NULL;
*proc_count = 0; *proc_count = 0;
#if defined(__APPLE__) || defined(BSD) #ifdef WIN32
PROCESSENTRY32 pe;
// Snapshot of all processes.
HANDLE h = CreateToolhelp32Snapshot(TH32CS_SNAPPROCESS, 0);
if(h == INVALID_HANDLE_VALUE) {
return 2;
}
pe.dwSize = sizeof(PROCESSENTRY32);
// Get root process.
if(!Process32First(h, &pe)) {
CloseHandle(h);
return 2;
}
// Collect processes whose parent matches `ppid`.
do {
if (pe.th32ParentProcessID == (DWORD)ppid) {
temp = xrealloc(temp, (*proc_count + 1) * sizeof(*temp));
temp[*proc_count] = (int)pe.th32ProcessID;
(*proc_count)++;
}
} while (Process32Next(h, &pe));
CloseHandle(h);
#elif defined(__APPLE__) || defined(BSD)
# if defined(__APPLE__) # if defined(__APPLE__)
# define KP_PID(o) o.kp_proc.p_pid # define KP_PID(o) o.kp_proc.p_pid
# define KP_PPID(o) o.kp_eproc.e_ppid # define KP_PPID(o) o.kp_eproc.e_ppid