mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2026-05-02 12:04:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(lsp): send didOpen on save to all clients+groups #37454

Browse Source 
Problem: _get_and_set_name edits the name for the whole group,
thus only one client per group gets the didOpen message.

Solution: move the logic to _changetracking and loop over every
client per group.
This commit is contained in:
Emilv2
2026-04-12 16:56:12 +02:00
committed by GitHub
parent b7cbad7489
commit 37eb1b9979
3 changed files with 78 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
test/functional/plugin/lsp_spec.lua
View File

@@ -815,6 +815,34 @@ describe('LSP', function()
}
end)
it('saveas sends didOpen to multiple attached servers if filename changed', function()
local tmpfile_new = tmpname(false)
exec_lua(create_server_definition)
local messages = exec_lua(function()
local server1 = _G._create_server()
local server2 = _G._create_server()
local client1_id = assert(vim.lsp.start({ name = 'dummy1', cmd = server1.cmd }))
local client2_id = assert(vim.lsp.start({ name = 'dummy2', cmd = server2.cmd }))
vim.cmd('saveas ' .. tmpfile_new)
vim.lsp.get_client_by_id(client1_id):stop()
vim.lsp.get_client_by_id(client2_id):stop()
return {
server1 = server1.messages,
server2 = server2.messages,
}
end)
eq('textDocument/didClose', messages.server1[3].method)
eq('textDocument/didOpen', messages.server1[4].method)
eq('textDocument/didSave', messages.server1[5].method)
eq('textDocument/didClose', messages.server2[3].method)
eq('textDocument/didOpen', messages.server2[4].method)
eq('textDocument/didSave', messages.server2[5].method)
end)
it('BufWritePre does not send notifications if server lacks willSave capabilities', function()
exec_lua(create_server_definition)
local messages = exec_lua(function()