mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2026-04-19 14:00:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(diagnostic): check for extmark in get_logical_pos #37127

Browse Source 
Problem: The function get_logical_pos did not account for the possibility that a diagnostic might not have an associated extmark, leading to potential errors or incorrect behavior.

Solution: Add a check for diagnostic._extmark_id and return the logical positions directly if it does not exist.
This commit is contained in:
Kira Kawai
2026-01-02 15:49:28 +09:00
committed by GitHub
parent ed562c296a
commit 3ac76977bc
2 changed files with 19 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
test/functional/lua/diagnostic_spec.lua
View File

@@ -608,6 +608,21 @@ describe('vim.diagnostic', function()
vim.diagnostic.hide(_G.diagnostic_ns)
end)
end)
it('handles diagnostics without extmark_id', function()
exec_lua(function()
vim.diagnostic.config({ virtual_text = true })
vim.diagnostic.set(_G.diagnostic_ns, _G.diagnostic_bufnr, {
_G.make_error('Error message', 0, 0, 0, 5),
})
local diags = vim.diagnostic.get(_G.diagnostic_bufnr, { namespace = _G.diagnostic_ns })
diags[1]._extmark_id = nil
vim.diagnostic.show(_G.diagnostic_ns, _G.diagnostic_bufnr, diags)
end)
end)
end)
describe('enable() and disable()', function()