mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-10-03 08:28:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: remove unnecessary volatile #19210

Browse Source 
libuv does not call callback functions(uv_signal_cb) directly from signal
handlers. Therefore, there is no need to use volatile.

Ref. 1a91b51976/src/unix/signal.c (L183)
This commit is contained in:
erw7
2022-07-04 19:28:59 +09:00
committed by GitHub
parent f075feee32
commit 436747752b
3 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/nvim/globals.h
View File

@@ -503,8 +503,7 @@ EXTERN int stdout_isatty INIT(= true);
EXTERN int stdin_fd INIT(= -1); EXTERN int stdin_fd INIT(= -1);
// true when doing full-screen output, otherwise only writing some messages. // true when doing full-screen output, otherwise only writing some messages.
// volatile because it is used in a signal handler. EXTERN int full_screen INIT(= false);
EXTERN volatile int full_screen INIT(= false);
/// Non-zero when only "safe" commands are allowed, e.g. when sourcing .exrc or /// Non-zero when only "safe" commands are allowed, e.g. when sourcing .exrc or
/// .vimrc in current directory. /// .vimrc in current directory.
@@ -724,7 +723,8 @@ EXTERN bool need_highlight_changed INIT(= true);
EXTERN FILE *scriptout INIT(= NULL); ///< Stream to write script to. EXTERN FILE *scriptout INIT(= NULL); ///< Stream to write script to.
// volatile because it is used in a signal handler. // Note that even when handling SIGINT, volatile is not necessary because the
// callback is not called directly from the signal handlers.
EXTERN bool got_int INIT(= false); // set to true when interrupt signal occurred EXTERN bool got_int INIT(= false); // set to true when interrupt signal occurred
EXTERN bool bangredo INIT(= false); // set to true with ! command EXTERN bool bangredo INIT(= false); // set to true with ! command
EXTERN int searchcmdlen; // length of previous search cmd EXTERN int searchcmdlen; // length of previous search cmd

3
src/nvim/os/signal.c
View File

@@ -165,8 +165,7 @@ static char *signal_name(int signum)
// This function handles deadly signals. // This function handles deadly signals.
// It tries to preserve any swap files and exit properly. // It tries to preserve any swap files and exit properly.
// (partly from Elvis). // (partly from Elvis).
// NOTE: Avoid unsafe functions, such as allocating memory, they can result in // NOTE: this is scheduled on the event loop, not called directly from a signal handler.
// a deadlock.
static void deadly_signal(int signum) static void deadly_signal(int signum)
FUNC_ATTR_NORETURN FUNC_ATTR_NORETURN
{ {

2
src/nvim/tui/tui.c
View File

@@ -137,7 +137,7 @@ struct TUIData {
char *space_buf; char *space_buf;
}; };
static bool volatile got_winch = false; static bool got_winch = false;
static bool did_user_set_dimensions = false; static bool did_user_set_dimensions = false;
static bool cursor_style_enabled = false; static bool cursor_style_enabled = false;