mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-12-15 19:05:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

lsp: fix textDocument/completion handling

Browse Source 
fix: #11826
Some lanuguage servers return complementary candidates whose prefixes do not match are also returned.
So we exclude completion candidates whose prefix does not match.
ex) Microsoft python-language-server, rust-analyzer
This commit is contained in:
Hirokazu Hata
2020-02-18 13:38:52 +09:00
parent e2ed8053bf
commit 4ac376740c
3 changed files with 21 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
runtime/lua/vim/lsp/util.lua
View File

@@ -129,6 +129,19 @@ function M.extract_completion_items(result)
end
end
-- Some lanuguage servers return complementary candidates whose prefixes do not match are also returned.
-- So we exclude completion candidates whose prefix does not match.
function M.remove_unmatch_completion_items(items, prefix)
local matched_items = {}
for _, item in ipairs(items) do
local word = item.insertText or item.label
if vim.startswith(word, prefix) then
table.insert(matched_items, item)
end
end
return matched_items
end
--- Apply the TextDocumentEdit response.
-- @params TextDocumentEdit [table] see https://microsoft.github.io/language-server-protocol/specification
function M.apply_text_document_edit(text_document_edit)
@@ -151,12 +164,14 @@ end
--- Getting vim complete-items with incomplete flag.
-- @params CompletionItem[], CompletionList or nil (https://microsoft.github.io/language-server-protocol/specification#textDocument_completion)
-- @return { matches = complete-items table, incomplete = boolean }
function M.text_document_completion_list_to_complete_items(result)
function M.text_document_completion_list_to_complete_items(result, prefix)
local items = M.extract_completion_items(result)
if vim.tbl_isempty(items) then
return {}
end
items = M.remove_unmatch_completion_items(items, prefix)
local matches = {}
for _, completion_item in ipairs(items) do