mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2026-04-02 05:39:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(api): nvim_set_hl{update:boolean} #37546

Browse Source 
Problem: nvim_set_hl always replaces all attributes.

Solution: Add update field. When true, merge with existing
attributes instead of replacing. Unspecified attributes are preserved.
If highlight group doesn't exist, falls back to reset mode.
This commit is contained in:
glepnir
2026-03-25 18:01:50 +08:00
committed by GitHub
parent 170ff4b244
commit 4d04d0123d
10 changed files with 138 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/nvim/api/keysets_defs.h
View File

@@ -206,6 +206,7 @@ typedef struct {
Boolean fg_indexed;
Boolean bg_indexed;
Boolean force;
Boolean update;
String url;
} Dict(highlight);

12
src/nvim/api/vim.c
View File

@@ -170,9 +170,8 @@ DictAs(get_hl_info) nvim_get_hl(Integer ns_id, Dict(get_highlight) *opts, Arena
/// - underdotted: boolean
/// - underdouble: boolean
/// - underline: boolean
/// - update: boolean false by default; true updates only specified attributes, leaving others unchanged.
/// @param[out] err Error details, if any
///
// TODO(bfredl): val should take update vs reset flag
void nvim_set_hl(uint64_t channel_id, Integer ns_id, String name, Dict(highlight) *val, Error *err)
FUNC_API_SINCE(7)
{
@@ -188,7 +187,14 @@ void nvim_set_hl(uint64_t channel_id, Integer ns_id, String name, Dict(highlight
return;
}
HlAttrs attrs = dict2hlattrs(val, true, &link_id, err);
bool update = HAS_KEY(val, highlight, update) && val->update;
HlAttrs *base = NULL;
HlAttrs base_attrs;
if (update && hl_ns_get_attrs((int)ns_id, hl_id, NULL, &base_attrs)) {
base = &base_attrs;
}
HlAttrs attrs = dict2hlattrs(val, true, &link_id, base, err);
if (!ERROR_SET(err)) {
WITH_SCRIPT_CONTEXT(channel_id, {
ns_hl_def((NS)ns_id, hl_id, attrs, link_id, val);