build: prefer -D <variable>=<value> over -D<variable>=<value> (#22164)

This makes it easier to see that -D is referring to the entire
"<variable>=<value>", rather than only <variable>. It also help syntax
highlighters highlight built-in variables.
This commit is contained in:
dundargoc
2023-02-08 11:00:16 +01:00
committed by GitHub
parent 645daaf5e9
commit 4d2c1004e9
11 changed files with 94 additions and 94 deletions

View File

@@ -449,12 +449,12 @@ set(gen_cflags ${gen_cflags} -O2)
set(NVIM_VERSION_GIT_H ${PROJECT_BINARY_DIR}/cmake.config/auto/versiondef_git.h)
add_custom_target(update_version_stamp
COMMAND ${CMAKE_COMMAND}
-DNVIM_VERSION_MAJOR=${NVIM_VERSION_MAJOR}
-DNVIM_VERSION_MINOR=${NVIM_VERSION_MINOR}
-DNVIM_VERSION_PATCH=${NVIM_VERSION_PATCH}
-DNVIM_VERSION_PRERELEASE=${NVIM_VERSION_PRERELEASE}
-DOUTPUT=${NVIM_VERSION_GIT_H}
-DNVIM_SOURCE_DIR=${CMAKE_SOURCE_DIR}
-D NVIM_VERSION_MAJOR=${NVIM_VERSION_MAJOR}
-D NVIM_VERSION_MINOR=${NVIM_VERSION_MINOR}
-D NVIM_VERSION_PATCH=${NVIM_VERSION_PATCH}
-D NVIM_VERSION_PRERELEASE=${NVIM_VERSION_PRERELEASE}
-D OUTPUT=${NVIM_VERSION_GIT_H}
-D NVIM_SOURCE_DIR=${CMAKE_SOURCE_DIR}
-P ${PROJECT_SOURCE_DIR}/cmake/GenerateVersion.cmake
BYPRODUCTS ${NVIM_VERSION_GIT_H})
@@ -706,9 +706,9 @@ if(WIN32)
add_custom_target(nvim_dll_deps DEPENDS nvim
COMMAND ${CMAKE_COMMAND} -E make_directory ${PROJECT_BINARY_DIR}/windows_runtime_deps
COMMAND ${CMAKE_COMMAND}
"-DCMAKE_PREFIX_PATH=${CMAKE_PREFIX_PATH}"
-DBINARY="${PROJECT_BINARY_DIR}/bin/nvim${CMAKE_EXECUTABLE_SUFFIX}"
-DDST=${PROJECT_BINARY_DIR}/windows_runtime_deps
-D CMAKE_PREFIX_PATH=${CMAKE_PREFIX_PATH}
-D BINARY="${PROJECT_BINARY_DIR}/bin/nvim${CMAKE_EXECUTABLE_SUFFIX}"
-D DST=${PROJECT_BINARY_DIR}/windows_runtime_deps
-P ${PROJECT_SOURCE_DIR}/cmake/WindowsDllCopy.cmake)
add_dependencies(nvim_runtime_deps nvim_dll_deps)

View File

@@ -100,12 +100,12 @@ if(HAVE_WORKING_LIBINTL AND GETTEXT_FOUND AND XGETTEXT_PRG AND ICONV_PRG)
add_custom_target(update-po-${lang}
COMMAND ${CMAKE_COMMAND}
-DICONV_PRG=${ICONV_PRG}
-DINPUT_FILE=${inputFile}
-DOUTPUT_FILE=${outputFile}
-DINPUT_ENC=${inputEnc}
-DOUTPUT_ENC=${outputEnc}
-DOUTPUT_CHARSET=${outputCharSet}
-D ICONV_PRG=${ICONV_PRG}
-D INPUT_FILE=${inputFile}
-D OUTPUT_FILE=${outputFile}
-D INPUT_ENC=${inputEnc}
-D OUTPUT_ENC=${outputEnc}
-D OUTPUT_CHARSET=${outputCharSet}
-P ${PROJECT_SOURCE_DIR}/cmake/ConvertPo.cmake
COMMENT "Updating ${outputName}.po"
DEPENDS ${inputFile})