mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-09-06 03:18:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

vim-patch:8.2.4647: "source" can read past end of copied line

Browse Source 
Problem:    "source" can read past end of copied line.
Solution:   Add a terminating NUL.

2bdad61267

Co-authored-by: Bram Moolenaar <Bram@vim.org>
This commit is contained in:
zeertzjq
2024-04-24 19:52:01 +08:00
parent 7c6a9c5589
commit 4e25b1a675
2 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/nvim/runtime.c
View File

@@ -2723,7 +2723,9 @@ static char *get_one_sourceline(source_cookie_T *sp)
} }
ga_concat(&ga, ((char **)sp->buflines.ga_data)[sp->buf_lnum]); ga_concat(&ga, ((char **)sp->buflines.ga_data)[sp->buf_lnum]);
sp->buf_lnum++; sp->buf_lnum++;
ga_grow(&ga, 1);
buf = (char *)ga.ga_data; buf = (char *)ga.ga_data;
buf[ga.ga_len++] = NUL;
} else { } else {
buf = ga.ga_data; buf = ga.ga_data;
retry: retry:

9
test/old/testdir/test_source.vim
View File

@@ -638,4 +638,13 @@ func Test_source_buffer_vim9()
%bw! %bw!
endfunc endfunc
func Test_source_buffer_long_line()
" This was reading past the end of the line.
new
norm300gr0
so
bwipe!
endfunc
" vim: shiftwidth=2 sts=2 expandtab " vim: shiftwidth=2 sts=2 expandtab