mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2026-05-24 05:40:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(lsp): fix typing for LSP methods #39099

Browse Source 
Problem
Some variables use the wrong type (ClientToServer instead of ServerToClient)
and some use vaguer types that could be more strict.

Solution
Use the correct types.
This commit is contained in:
Luis Calle
2026-04-16 02:57:13 -05:00
committed by GitHub
parent 0e07b2a1e2
commit 530cfa1323
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
runtime/lua/vim/lsp/rpc.lua
View File

@@ -147,8 +147,8 @@ end
--- Dispatchers for LSP message types.
--- @class vim.lsp.rpc.Dispatchers
--- @inlinedoc
--- @field notification fun(method: vim.lsp.protocol.Method.ClientToServer.Notification, params: table)
--- @field server_request fun(method: vim.lsp.protocol.Method.ClientToServer.Request, params: table): any?, lsp.ResponseError?
--- @field notification fun(method: vim.lsp.protocol.Method.ServerToClient, params: table)
--- @field server_request fun(method: vim.lsp.protocol.Method.ServerToClient, params: table): any?, lsp.ResponseError?
--- @field on_exit fun(code: integer, signal: integer)
--- @field on_error fun(code: integer, err: any)
@@ -156,7 +156,7 @@ end
local default_dispatchers = {
--- Default dispatcher for notifications sent to an LSP server.
---
---@param method vim.lsp.protocol.Method The invoked LSP method
---@param method vim.lsp.protocol.Method.ServerToClient The invoked LSP method
---@param params table Parameters for the invoked LSP method
notification = function(method, params)
log.debug('notification', method, params)
@@ -164,7 +164,7 @@ local default_dispatchers = {
--- Default dispatcher for requests sent to an LSP server.
---
---@param method vim.lsp.protocol.Method The invoked LSP method
---@param method vim.lsp.protocol.Method.ServerToClient The invoked LSP method
---@param params table Parameters for the invoked LSP method
---@return any result (always nil for the default dispatchers)
---@return lsp.ResponseError error `vim.lsp.protocol.ErrorCodes.MethodNotFound`
@@ -354,7 +354,7 @@ end
---@package
--- Sends a notification to the LSP server.
---@param method vim.lsp.protocol.Method The invoked LSP method
---@param method vim.lsp.protocol.Method.ClientToServer.Notification The invoked LSP method
---@param params any Parameters for the invoked LSP method
---@return boolean `true` if notification could be sent, `false` if not
function Client:_notify(method, params)
@@ -379,7 +379,7 @@ end
---@package
--- Sends a request to the LSP server and runs {callback} upon response. |vim.lsp.rpc.request()|
---
---@param method vim.lsp.protocol.Method The invoked LSP method
---@param method vim.lsp.protocol.Method.ClientToServer.Request The invoked LSP method
---@param params table? Parameters for the invoked LSP method
---@param callback fun(err?: lsp.ResponseError, result: any, message_id: integer) Callback to invoke
---@param notify_reply_callback? fun(message_id: integer) Callback to invoke as soon as a request is no longer pending