mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2026-08-28 10:01:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(lsp): don't send foreign diagnostics to servers in buf.code_action (#29501)

Browse Source 
`buf.code_action` always included diagnostics on a given line from all
clients. Servers should only receive diagnostics they published, and in
the exact same format they sent it.

Should fix https://github.com/neovim/neovim/issues/29500

(cherry picked from commit 720b309c78)
This commit is contained in:
Mathias Fußenegger
2024-08-01 16:01:15 +02:00
committed by Christian Clason
parent 3af1495af0
commit 5955ef0ba8
3 changed files with 21 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
test/functional/plugin/lsp/diagnostic_spec.lua
View File

@@ -98,33 +98,6 @@ describe('vim.lsp.diagnostic', function()
clear()
end)
describe('vim.lsp.diagnostic', function()
it('maintains LSP information when translating diagnostics', function()
local result = exec_lua [[
local diagnostics = {
make_error("Error 1", 1, 1, 1, 5),
}
diagnostics[1].code = 42
diagnostics[1].data = "Hello world"
vim.lsp.diagnostic.on_publish_diagnostics(nil, {
uri = fake_uri,
diagnostics = diagnostics,
}, {client_id=client_id})
return {
vim.diagnostic.get(diagnostic_bufnr, {lnum=1})[1],
vim.lsp.diagnostic.get_line_diagnostics(diagnostic_bufnr, 1)[1],
}
]]
eq({ code = 42, data = 'Hello world' }, result[1].user_data.lsp)
eq(42, result[1].code)
eq(42, result[2].code)
eq('Hello world', result[2].data)
end)
end)
describe('vim.lsp.diagnostic.on_publish_diagnostics', function()
it('allows configuring the virtual text via vim.lsp.with', function()
local expected_spacing = 10