mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-10-26 12:27:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(api): ignore 'autochdir' when renaming other buf (#28376)

Browse Source 
Problem:  Renaming non-current buffer changes working directory when
          'autochdir' is set.
Solution: Temporarily disable 'autochdir'.  Add more tests for the
          win_set_buf change.
This commit is contained in:
zeertzjq
2024-04-16 20:57:01 +08:00
committed by GitHub
parent 2fc2343728
commit 5cfdaaaeac
5 changed files with 130 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

99
test/functional/api/window_spec.lua
View File

@@ -111,6 +111,44 @@ describe('API/win', function()
api.nvim_win_set_buf(new_win, next_buf)
eq(next_buf, api.nvim_win_get_buf(new_win))
end)
describe("with 'autochdir'", function()
local topdir
local otherbuf
local oldwin
local newwin
before_each(function()
command('set shellslash')
topdir = fn.getcwd()
t.mkdir(topdir .. '/Xacd')
t.mkdir(topdir .. '/Xacd/foo')
otherbuf = api.nvim_create_buf(false, true)
api.nvim_buf_set_name(otherbuf, topdir .. '/Xacd/baz.txt')
command('set autochdir')
command('edit Xacd/foo/bar.txt')
eq(topdir .. '/Xacd/foo', fn.getcwd())
oldwin = api.nvim_get_current_win()
command('vsplit')
newwin = api.nvim_get_current_win()
end)
after_each(function()
t.rmdir(topdir .. '/Xacd')
end)
it('does not change cwd with non-current window', function()
api.nvim_win_set_buf(oldwin, otherbuf)
eq(topdir .. '/Xacd/foo', fn.getcwd())
end)
it('changes cwd with current window', function()
api.nvim_win_set_buf(newwin, otherbuf)
eq(topdir .. '/Xacd', fn.getcwd())
end)
end)
end)
describe('{get,set}_cursor', function()
@@ -1749,29 +1787,44 @@ describe('API/win', function()
)
end)
it('do not change dir when enter is false', function()
local expected = fn.getcwd() .. '/foo'
t.mkdir('foo')
exec_lua [[
vim.opt.autochdir = true
local buf = vim.api.nvim_create_buf(false, true)
vim.api.nvim_buf_set_name(buf, 'Foo')
vim.api.nvim_create_autocmd('CmdlineEnter', {
callback = function()
local winid = vim.api.nvim_open_win(buf, false, {
relative = 'editor',
height = 1,
width = 1,
row = 1,
col = 1,
})
vim.api.nvim_win_close(winid, true)
end,
})
]]
t.feed(':edit foo/bar.txt<CR>')
eq(t.is_os('win') and expected:gsub('/', '\\') or expected, fn.getcwd())
t.rmdir('foo')
describe("with 'autochdir'", function()
local topdir
local otherbuf
before_each(function()
command('set shellslash')
topdir = fn.getcwd()
t.mkdir(topdir .. '/Xacd')
t.mkdir(topdir .. '/Xacd/foo')
otherbuf = api.nvim_create_buf(false, true)
api.nvim_buf_set_name(otherbuf, topdir .. '/Xacd/baz.txt')
command('set autochdir')
command('edit Xacd/foo/bar.txt')
eq(topdir .. '/Xacd/foo', fn.getcwd())
end)
after_each(function()
t.rmdir(topdir .. '/Xacd')
end)
it('does not change cwd with enter=false #15280', function()
api.nvim_open_win(
otherbuf,
false,
{ relative = 'editor', height = 5, width = 5, row = 5, col = 5 }
)
eq(topdir .. '/Xacd/foo', fn.getcwd())
end)
it('changes cwd with enter=true', function()
api.nvim_open_win(
otherbuf,
true,
{ relative = 'editor', height = 5, width = 5, row = 5, col = 5 }
)
eq(topdir .. '/Xacd', fn.getcwd())
end)
end)
end)