mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-09-06 11:28:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(vim.ui.open): use explorer.exe instead of wslview #26947

Browse Source 
Problem:
`vim.ui.open` uses `wslview`, which is slow and require a package from external PPA:
https://wslutiliti.es/wslu/install.html#ubuntu

Solution:
Use `explorer.exe` instead. WSL supports it by default:
https://learn.microsoft.com/en-us/windows/wsl/filesystems#view-your-current-directory-in-windows-file-explorer
This commit is contained in:
Vu Nhat Chuong
2024-02-21 00:14:50 +07:00
committed by GitHub
parent eb1e8c12e2
commit 5e4a5f1aaa
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
runtime/lua/vim/ui.lua
View File

@@ -143,12 +143,12 @@ function M.open(path)
else else
return nil, 'vim.ui.open: rundll32 not found' return nil, 'vim.ui.open: rundll32 not found'
end end
elseif vim.fn.executable('wslview') == 1 then elseif vim.fn.executable('explorer.exe') == 1 then
cmd = { 'wslview', path } cmd = { 'explorer.exe', path }
elseif vim.fn.executable('xdg-open') == 1 then elseif vim.fn.executable('xdg-open') == 1 then
cmd = { 'xdg-open', path } cmd = { 'xdg-open', path }
else else
return nil, 'vim.ui.open: no handler found (tried: wslview, xdg-open)' return nil, 'vim.ui.open: no handler found (tried: explorer.exe, xdg-open)'
end end
local rv = vim.system(cmd, { text = true, detach = true }):wait() local rv = vim.system(cmd, { text = true, detach = true }):wait()

2
test/functional/lua/ui_spec.lua
View File

@@ -152,7 +152,7 @@ describe('vim.ui', function()
vim.fn.executable = function() return 0 end vim.fn.executable = function() return 0 end
]] ]]
eq( eq(
'vim.ui.open: no handler found (tried: wslview, xdg-open)', 'vim.ui.open: no handler found (tried: explorer.exe, xdg-open)',
exec_lua [[local _, err = vim.ui.open('foo') ; return err]] exec_lua [[local _, err = vim.ui.open('foo') ; return err]]
) )
end) end)