diff --git a/src/nvim/buffer.c b/src/nvim/buffer.c index c380b14c67..8e6794bc0f 100644 --- a/src/nvim/buffer.c +++ b/src/nvim/buffer.c @@ -1638,6 +1638,7 @@ void set_curbuf(buf_T *buf, int action, bool update_jumplist) bufref_T prevbufref; set_bufref(&prevbufref, prevbuf); set_bufref(&newbufref, buf); + const int prev_nwindows = prevbuf->b_nwindows; // Autocommands may delete the current buffer and/or the buffer we want to // go to. In those cases don't close the buffer. @@ -1650,8 +1651,8 @@ void set_curbuf(buf_T *buf, int action, bool update_jumplist) // autocommands may have opened a new window // with prevbuf, grr if (unload - || (last_winid != get_last_winid() - && strchr("wdu", prevbuf->b_p_bh[0]) != NULL)) { + || (prev_nwindows <= 1 && last_winid != get_last_winid() + && action == DOBUF_GOTO && !buf_hide(prevbuf))) { close_windows(prevbuf, false); } if (bufref_valid(&prevbufref) && !aborting()) { diff --git a/test/old/testdir/test_autocmd.vim b/test/old/testdir/test_autocmd.vim index da5ff00b13..252162f6f1 100644 --- a/test/old/testdir/test_autocmd.vim +++ b/test/old/testdir/test_autocmd.vim @@ -4008,7 +4008,7 @@ func Test_autocmd_invalidates_undo_on_textchanged() call StopVimInTerminal(buf) endfunc -func Test_autocmd_creates_new_buffer_on_bufleave() +func Test_autocmd_creates_new_window_on_bufleave() e a.txt e b.txt setlocal bufhidden=wipe diff --git a/test/old/testdir/test_buffer.vim b/test/old/testdir/test_buffer.vim index ae7b471916..5448721dc6 100644 --- a/test/old/testdir/test_buffer.vim +++ b/test/old/testdir/test_buffer.vim @@ -868,4 +868,37 @@ func Test_bdelete_skip_closing_bufs() %bw! endfunc +func Test_split_window_in_BufLeave_from_tab_sbuffer() + tabnew Xa + setlocal bufhidden=wipe + let t0 = tabpagenr() + let b0 = bufnr() + let b1 = bufadd('Xb') + autocmd BufLeave Xa ++once split + exe 'tab sbuffer' b1 + call assert_equal(t0 + 1, tabpagenr()) + call assert_equal([b1, b0], tabpagebuflist()) + call assert_equal([b0], tabpagebuflist(t0)) + tabclose + call assert_equal(t0, tabpagenr()) + call assert_equal([b0], tabpagebuflist()) + + bwipe! Xa + bwipe! Xb +endfunc + +func Test_split_window_in_BufLeave_from_switching_buffer() + tabnew Xa + setlocal bufhidden=wipe + split + let b0 = bufnr() + let b1 = bufadd('Xb') + autocmd BufLeave Xa ++once split + exe 'buffer' b1 + call assert_equal([b1, b0, b0], tabpagebuflist()) + + bwipe! Xa + bwipe! Xb +endfunc + " vim: shiftwidth=2 sts=2 expandtab