mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2026-04-22 07:15:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(api): buffer overflow in nvim_buf_get_extmarks overlap #37184

Browse Source 
With `overlap=true`, more extmarks than the requested limit may be
collected in `extmark_get`. This then leads to an out of bounds write of
`rv` in `nvim_buf_get_extmarks`.
This commit is contained in:
Francisco Giordano
2026-01-02 04:17:57 -03:00
committed by GitHub
parent a03ab03a10
commit 612cd99a00
2 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
test/functional/api/extmark_spec.lua
View File

@@ -817,6 +817,15 @@ describe('API/extmarks', function()
get_extmarks(ns, { 2, 0 }, { 2, -1 }, { overlap = true })
)
end)
it('limits overlap results', function()
set_extmark(ns, 1, 0, 0, { end_row = 5, end_col = 0 })
set_extmark(ns, 2, 2, 5, { end_row = 2, end_col = 30 })
set_extmark(ns, 3, 0, 5, { end_row = 2, end_col = 10 })
set_extmark(ns, 4, 0, 0, { end_row = 1, end_col = 0 })
local rv = get_extmarks(ns, { 2, 0 }, { 2, -1 }, { overlap = true, limit = 1 })
eq(1, #rv)
end)
end)
it('replace works', function()