mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-10-10 03:46:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(nvim_open_term): convert LF => CRLF (#26384)

Browse Source 
Problem:
Unlike termopen(), nvim_open_term() PTYs do not carriage-return the
cursor on newline ("\n") input.

    nvim --clean
    :let chan_id = nvim_open_term(1, {})
    :call chansend(chan_id, ["here", "are", "some", "lines"])

Actual behavior:

    here
        are
           some
               lines

Expected behaviour:

    here
    are
    some
    lines

Solution:
Add `force_crlf` option, and enable it by default.
This commit is contained in:
Raphael
2023-12-14 16:08:00 +08:00
committed by GitHub
parent 36552adb39
commit 619407eb54
11 changed files with 91 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/nvim/terminal.c
View File

@@ -43,6 +43,7 @@
#include <vterm.h>
#include <vterm_keycodes.h>
#include "klib/kvec.h"
#include "nvim/api/private/defs.h"
#include "nvim/api/private/helpers.h"
#include "nvim/ascii_defs.h"
@@ -80,6 +81,7 @@
#include "nvim/optionstr.h"
#include "nvim/pos_defs.h"
#include "nvim/state.h"
#include "nvim/strings.h"
#include "nvim/terminal.h"
#include "nvim/types_defs.h"
#include "nvim/ui.h"
@@ -786,7 +788,21 @@ void terminal_receive(Terminal *term, const char *data, size_t len)
return;
}
vterm_input_write(term->vt, data, len);
if (term->opts.force_crlf) {
StringBuilder crlf_data = KV_INITIAL_VALUE;
for (size_t i = 0; i < len; i++) {
if (data[i] == '\n' && (i == 0 || (i > 0 && data[i - 1] != '\r'))) {
kv_push(crlf_data, '\r');
}
kv_push(crlf_data, data[i]);
}
vterm_input_write(term->vt, crlf_data.items, kv_size(crlf_data));
kv_destroy(crlf_data);
} else {
vterm_input_write(term->vt, data, len);
}
vterm_screen_flush_damage(term->vts);
}