mirror of
https://github.com/neovim/neovim.git
synced 2025-10-05 17:36:29 +00:00
refactor(options): reduce findoption()
usage
Problem: Many places in the code use `findoption()` to access an option using its name, even if the option index is available. This is very slow because it requires looping through the options array over and over. Solution: Use option index instead of name wherever possible. Also introduce an `OptIndex` enum which contains the index for every option as enum constants, this eliminates the need to pass static option names as strings.
This commit is contained in:
@@ -1337,9 +1337,10 @@ void do_highlight(const char *line, const bool forceit, const bool init)
|
||||
// wrong.
|
||||
if (dark != -1
|
||||
&& dark != (*p_bg == 'd')
|
||||
&& !option_was_set("bg")) {
|
||||
set_option_value_give_err("bg", CSTR_AS_OPTVAL(dark ? "dark" : "light"), 0);
|
||||
reset_option_was_set("bg");
|
||||
&& !option_was_set(kOptBackground)) {
|
||||
set_option_value_give_err(kOptBackground,
|
||||
CSTR_AS_OPTVAL(dark ? "dark" : "light"), 0);
|
||||
reset_option_was_set(kOptBackground);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
Reference in New Issue
Block a user