diff --git a/src/nvim/insexpand.c b/src/nvim/insexpand.c index ab8bf2eec8..cd536144a0 100644 --- a/src/nvim/insexpand.c +++ b/src/nvim/insexpand.c @@ -2334,9 +2334,10 @@ static bool set_ctrl_x_mode(const int c) static bool ins_compl_stop(const int c, const int prev_mode, bool retval) { // Remove pre-inserted text when present. - if (ins_compl_preinsert_effect()) { + if (ins_compl_preinsert_effect() && ins_compl_win_active(curwin)) { ins_compl_delete(false); } + // Get here when we have finished typing a sequence of ^N and // ^P or other completion characters in CTRL-X mode. Free up // memory that was used, and make sure we can redo the insert. diff --git a/test/old/testdir/test_ins_complete.vim b/test/old/testdir/test_ins_complete.vim index 066a538906..ded4f7392e 100644 --- a/test/old/testdir/test_ins_complete.vim +++ b/test/old/testdir/test_ins_complete.vim @@ -3223,7 +3223,7 @@ func Test_complete_info_completed() set cot& endfunc -function Test_completeopt_preinsert() +func Test_completeopt_preinsert() func Omni_test(findstart, base) if a:findstart return col(".") @@ -3363,6 +3363,47 @@ function Test_completeopt_preinsert() call assert_equal(4, g:col) call assert_equal("wp.", getline('.')) + %delete _ + let &l:undolevels = &l:undolevels + normal! ifoo + let &l:undolevels = &l:undolevels + normal! obar + let &l:undolevels = &l:undolevels + normal! obaz + let &l:undolevels = &l:undolevels + + func CheckUndo() + let g:errmsg = '' + call assert_equal(['foo', 'bar', 'baz'], getline(1, '$')) + undo + call assert_equal(['foo', 'bar'], getline(1, '$')) + undo + call assert_equal(['foo'], getline(1, '$')) + undo + call assert_equal([''], getline(1, '$')) + later 3 + call assert_equal(['foo', 'bar', 'baz'], getline(1, '$')) + call assert_equal('', v:errmsg) + endfunc + + " Check that switching buffer with "preinsert" doesn't corrupt undo. + new + setlocal bufhidden=wipe + inoremap enew! + call feedkeys("i\\\\", 'tx') + bwipe! + call CheckUndo() + + " Check that closing window with "preinsert" doesn't corrupt undo. + new + setlocal bufhidden=wipe + inoremap close! + call feedkeys("i\\\\", 'tx') + call CheckUndo() + + %delete _ + delfunc CheckUndo + bw! set cot& set omnifunc&