mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-10-01 15:38:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

API: nvim_unsubscribe(): Handle unknown events #8745

Browse Source 
close #8745
This commit is contained in:
Daniel Hahler
2018-07-14 18:23:08 +02:00
committed by Justin M. Keyes
parent 10e885bdfc
commit 643ef257b3
2 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/nvim/msgpack_rpc/channel.c
View File

@@ -505,6 +505,11 @@ end:
static void unsubscribe(Channel *channel, char *event) static void unsubscribe(Channel *channel, char *event)
{ {
char *event_string = pmap_get(cstr_t)(event_strings, event); char *event_string = pmap_get(cstr_t)(event_strings, event);
if (!event_string) {
WLOG("RPC: ch %" PRIu64 ": tried to unsubscribe unknown event '%s'",
channel->id, event);
return;
}
pmap_del(cstr_t)(channel->rpc.subscribed_events, event_string); pmap_del(cstr_t)(channel->rpc.subscribed_events, event_string);
map_foreach_value(channels, channel, { map_foreach_value(channels, channel, {

7
test/functional/api/server_notifications_spec.lua
View File

@@ -65,4 +65,11 @@ describe('notify', function()
eq(nest_level, act_nest_level) eq(nest_level, act_nest_level)
end) end)
end) end)
it('unsubscribe non-existing event #8745', function()
nvim('subscribe', 'event1')
nvim('unsubscribe', 'doesnotexist')
nvim('unsubscribe', 'event1')
eq(2, eval('1+1')) -- Still alive?
end)
end) end)