From 6bd2f603aa740dba89c232af474110614846d81c Mon Sep 17 00:00:00 2001 From: "Justin M. Keyes" Date: Mon, 20 Apr 2026 08:05:03 -0400 Subject: [PATCH] ci(backport): drop `needs:backport` label #39244 Problem: When auto-backport fails, it adds a `needs:backport` label. But that label isn't being used AFAIK, based on the fact there were 30+ old PRs with that label from last year (I have since cleaned those up). So the extra step of having to remove the label is unnecessary friction. In practice, when a manual backport is needed, it's best to either do it immediately or just remove the `backport-xx` label. Also, the presence of an unresolved "Failed backport" comment from the bot is already a kind of marker that indicates a backport is needed. Solution: Don't add `needs:backport` label on failed backport. Reverts https://github.com/neovim/neovim/pull/30363 --- .github/workflows/backport.yml | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/.github/workflows/backport.yml b/.github/workflows/backport.yml index 3d16a5fa2b..6275e61f5a 100644 --- a/.github/workflows/backport.yml +++ b/.github/workflows/backport.yml @@ -32,18 +32,6 @@ jobs: label_pattern: "^ci:backport ([^ ]+)$" github_token: ${{ steps.app-token.outputs.token }} - - name: Create failed backport label - if: ${{ steps.backport.outputs.was_successful == 'false' }} - uses: actions/github-script@v9 - with: - script: | - github.rest.issues.addLabels({ - issue_number: context.issue.number, - owner: context.repo.owner, - repo: context.repo.repo, - labels: ['needs:backport'] - }) - - name: Enable automerge if: ${{ steps.backport.outputs.was_successful == 'true' }} env: