mirror of
https://github.com/neovim/neovim.git
synced 2026-08-28 01:51:52 +00:00
test(harness): migrate away from magic globals
Problem: The magic globals `it`, `describe`, etc., are more trouble than they are worth. - Hooking into `after_each` requires `getfenv()` hacks. - They confuse luals/emmylua, because the top-level `.luarc.json` isn't merged with `test/.luarc.json` (apparently a luals limitation?) - They totally defeat discoverability because the user just has to "know" about the various magic symbols. So they harm DX, which means they serve no purpose at all. Solution: - Expose the test API from `testutil`, so tests can call `t.it()`, `t.describe()`, etc., in the conventional way. - Drop `getfenv()` hacks. - Drop the `setfenv()` injection in `load_chunk`. - Drop `test/_meta.lua`.
This commit is contained in:
@@ -3,6 +3,8 @@
|
||||
local t = require('test.testutil')
|
||||
local n = require('test.functional.testnvim')()
|
||||
|
||||
local describe, it, before_each, after_each, pending, finally =
|
||||
t.describe, t.it, t.before_each, t.after_each, t.pending, t.finally
|
||||
local clear, eval = n.clear, n.eval
|
||||
local eq, neq, run, stop = t.eq, t.neq, n.run, n.stop
|
||||
local nvim_prog, command, fn = n.nvim_prog, n.command, n.fn
|
||||
|
||||
Reference in New Issue
Block a user