mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-09-23 11:38:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #14027 from dylanarmstrong/fix/13955-empty-paste-in-term-segfault

Browse Source 
fix: segfault when pasting in term with empty buffer
This commit is contained in:
Björn Linse
2021-04-02 23:15:43 +02:00
committed by GitHub
parent dde89730b4 42d2bbe7d0
commit 6db3ba9df2
2 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/nvim/terminal.c
View File

@@ -580,6 +580,9 @@ static bool is_filter_char(int c)
void terminal_paste(long count, char_u **y_array, size_t y_size) void terminal_paste(long count, char_u **y_array, size_t y_size)
{ {
if (y_size == 0) {
return;
}
vterm_keyboard_start_paste(curbuf->terminal->vt); vterm_keyboard_start_paste(curbuf->terminal->vt);
terminal_flush_output(curbuf->terminal); terminal_flush_output(curbuf->terminal);
size_t buff_len = STRLEN(y_array[0]); size_t buff_len = STRLEN(y_array[0]);

7
test/functional/terminal/buffer_spec.lua
View File

@@ -258,6 +258,13 @@ describe(':terminal buffer', function()
it('handles wqall', function() it('handles wqall', function()
eq('Vim(wqall):E948: Job still running', exc_exec('wqall')) eq('Vim(wqall):E948: Job still running', exc_exec('wqall'))
end) end)
it('does not segfault when pasting empty buffer #13955', function()
feed_command('terminal')
feed('<c-\\><c-n>')
feed_command('put a') -- buffer a is empty
helpers.assert_alive()
end)
end) end)
describe('No heap-buffer-overflow when using', function() describe('No heap-buffer-overflow when using', function()