mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-09-19 17:58:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

vim-patch:8.2.2887: crash when passing null string to fullcommand()

Browse Source 
Problem:    Crash when passing null string to fullcommand().
Solution:   Check for NULL pointer. (closes vim/vim#8256)
4c8e8c6e19
This commit is contained in:
zeertzjq
2022-01-05 22:11:28 +08:00
parent f65b0d4236
commit 6e1a59da6c
2 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/nvim/ex_docmd.c
View File

@@ -2891,13 +2891,17 @@ void f_fullcommand(typval_T *argvars, typval_T *rettv, FunPtr fptr)
exarg_T ea; exarg_T ea;
char_u *name = argvars[0].vval.v_string; char_u *name = argvars[0].vval.v_string;
while (name[0] != NUL && name[0] == ':') { rettv->v_type = VAR_STRING;
rettv->vval.v_string = NULL;
if (name == NULL) {
return;
}
while (*name != NUL && *name == ':') {
name++; name++;
} }
name = skip_range(name, NULL); name = skip_range(name, NULL);
rettv->v_type = VAR_STRING;
ea.cmd = (*name == '2' || *name == '3') ? name + 1 : name; ea.cmd = (*name == '2' || *name == '3') ? name + 1 : name;
ea.cmdidx = (cmdidx_T)0; ea.cmdidx = (cmdidx_T)0;
char_u *p = find_command(&ea, NULL); char_u *p = find_command(&ea, NULL);

1
src/nvim/testdir/test_cmdline.vim
View File

@@ -500,6 +500,7 @@ func Test_fullcommand()
for [in, want] in items(tests) for [in, want] in items(tests)
call assert_equal(want, fullcommand(in)) call assert_equal(want, fullcommand(in))
endfor endfor
call assert_equal('', fullcommand(v:_null_string))
call assert_equal('syntax', 'syn'->fullcommand()) call assert_equal('syntax', 'syn'->fullcommand())
endfunc endfunc