mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2026-07-22 09:01:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(float): title/footer shows printable control chars #40047

Browse Source 
Problem:
Literal tab (or other control char) in a float title/footer is
not made printable, so it renders incorrectly instead of as "^I".

Solution:
Normalize title/footer text for display like 'statusline'
tab to "^I", parameterize parse_virt_text() with untab
and recompute the width.
This commit is contained in:
glepnir
2026-05-30 22:02:16 +08:00
committed by GitHub
parent a9ef076817
commit 70cfeabe23
5 changed files with 58 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/nvim/api/extmark.c
View File

@@ -669,7 +669,7 @@ Integer nvim_buf_set_extmark(Buffer buf, Integer ns_id, Integer line, Integer co
}
if (HAS_KEY(opts, set_extmark, virt_text)) {
virt_text.data.virt_text = parse_virt_text(opts->virt_text, err, &virt_text.width);
virt_text.data.virt_text = parse_virt_text(opts->virt_text, err, &virt_text.width, false);
if (ERROR_SET(err)) {
goto error;
}
@@ -742,7 +742,7 @@ Integer nvim_buf_set_extmark(Buffer buf, Integer ns_id, Integer line, Integer co
goto error;
});
int dummig;
VirtText jtem = parse_virt_text(a.items[j].data.array, err, &dummig);
VirtText jtem = parse_virt_text(a.items[j].data.array, err, &dummig, false);
kv_push(virt_lines.data.virt_lines, ((struct virt_line){ jtem, virt_lines_flags }));
if (ERROR_SET(err)) {
goto error;
@@ -1192,7 +1192,7 @@ static bool extmark_get_index_from_obj(buf_T *buf, Integer ns_id, Object obj, in
}
}
VirtText parse_virt_text(Array chunks, Error *err, int *width)
VirtText parse_virt_text(Array chunks, Error *err, int *width, bool untab)
{
VirtText virt_text = KV_INITIAL_VALUE;
int w = 0;
@@ -1230,7 +1230,7 @@ VirtText parse_virt_text(Array chunks, Error *err, int *width)
}
}
char *text = transstr(str.size > 0 ? str.data : "", false); // allocates
char *text = transstr(str.size > 0 ? str.data : "", untab); // allocates
w += (int)mb_string2cells(text);
kv_push(virt_text, ((VirtTextChunk){ .text = text, .hl_id = hl_id }));