refactor(options): require enable_if = false iff no variable (#28050)

This makes grepping for unsupported options easier.
This commit is contained in:
zeertzjq
2024-03-28 06:02:49 +08:00
committed by GitHub
parent 997bef54aa
commit 7168000b53
2 changed files with 10 additions and 3 deletions

View File

@@ -165,17 +165,22 @@ local function dump_option(i, o)
w(get_cond(o.enable_if))
end
-- Options cannot be both hidden and immutable.
-- An option cannot be both hidden and immutable.
assert(not o.hidden or not o.immutable)
local has_var = true
if o.varname then
w(' .var=&' .. o.varname)
-- Hidden and immutable options can directly point to the default value.
elseif o.hidden or o.immutable then
-- Hidden and immutable options can directly point to the default value.
w((' .var=&options[%u].def_val'):format(i - 1))
elseif #o.scope == 1 and o.scope[1] == 'window' then
w(' .var=VAR_WIN')
else
has_var = false
end
-- `enable_if = false` should be present iff there is no variable.
assert((o.enable_if == false) == not has_var)
w(' .hidden=' .. (o.hidden and 'true' or 'false'))
w(' .immutable=' .. (o.immutable and 'true' or 'false'))
if #o.scope == 1 and o.scope[1] == 'global' then