refactor: fix clang-tidy warnings

Enable and fix bugprone-misplaced-widening-cast warning.

Fix some modernize-macro-to-enum and readability-else-after-return
warnings, but don't enable them. While the warnings can be useful, they
are in general too noisy to enable.
This commit is contained in:
dundargoc
2022-10-22 12:36:38 +02:00
parent a79d28e4d7
commit 731cdde28e
56 changed files with 558 additions and 555 deletions

View File

@@ -55,24 +55,26 @@
#define CTRL_X_WANT_IDENT 0x100
#define CTRL_X_NORMAL 0 ///< CTRL-N CTRL-P completion, default
#define CTRL_X_NOT_DEFINED_YET 1
#define CTRL_X_SCROLL 2
#define CTRL_X_WHOLE_LINE 3
#define CTRL_X_FILES 4
#define CTRL_X_TAGS (5 + CTRL_X_WANT_IDENT)
#define CTRL_X_PATH_PATTERNS (6 + CTRL_X_WANT_IDENT)
#define CTRL_X_PATH_DEFINES (7 + CTRL_X_WANT_IDENT)
#define CTRL_X_FINISHED 8
#define CTRL_X_DICTIONARY (9 + CTRL_X_WANT_IDENT)
#define CTRL_X_THESAURUS (10 + CTRL_X_WANT_IDENT)
#define CTRL_X_CMDLINE 11
#define CTRL_X_FUNCTION 12
#define CTRL_X_OMNI 13
#define CTRL_X_SPELL 14
#define CTRL_X_LOCAL_MSG 15 ///< only used in "ctrl_x_msgs"
#define CTRL_X_EVAL 16 ///< for builtin function complete()
#define CTRL_X_CMDLINE_CTRL_X 17 ///< CTRL-X typed in CTRL_X_CMDLINE
enum {
CTRL_X_NORMAL = 0, ///< CTRL-N CTRL-P completion, default
CTRL_X_NOT_DEFINED_YET = 1,
CTRL_X_SCROLL = 2,
CTRL_X_WHOLE_LINE = 3,
CTRL_X_FILES = 4,
CTRL_X_TAGS = (5 + CTRL_X_WANT_IDENT),
CTRL_X_PATH_PATTERNS = (6 + CTRL_X_WANT_IDENT),
CTRL_X_PATH_DEFINES = (7 + CTRL_X_WANT_IDENT),
CTRL_X_FINISHED = 8,
CTRL_X_DICTIONARY = (9 + CTRL_X_WANT_IDENT),
CTRL_X_THESAURUS = (10 + CTRL_X_WANT_IDENT),
CTRL_X_CMDLINE = 11,
CTRL_X_FUNCTION = 12,
CTRL_X_OMNI = 13,
CTRL_X_SPELL = 14,
CTRL_X_LOCAL_MSG = 15, ///< only used in "ctrl_x_msgs"
CTRL_X_EVAL = 16, ///< for builtin function complete()
CTRL_X_CMDLINE_CTRL_X = 17, ///< CTRL-X typed in CTRL_X_CMDLINE
};
#define CTRL_X_MSG(i) ctrl_x_msgs[(i) & ~CTRL_X_WANT_IDENT]