mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-09-29 22:48:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

coverity/13773: Resource leak: RI.

Browse Source 
Problem    : Resource leak @ 3324.
Diagnostic : Real issue.
Rationale  : Stack is not being freed on error cases.
Resolution : Free stack before invoking EMSG_RET_NULL.
This commit is contained in:
Eliseo Martínez
2015-02-04 12:39:57 +01:00
parent d7038127ca
commit 77ace65bdc
1 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/nvim/regexp_nfa.c
View File

@@ -2887,6 +2887,7 @@ static nfa_state_T *post2nfa(int *postfix, int *end, int nfa_calc_size)
if (stackp < stack) \ if (stackp < stack) \
{ \ { \
st_error(postfix, end, p); \ st_error(postfix, end, p); \
free(stack); \
return NULL; \ return NULL; \
} }
@@ -3316,13 +3317,17 @@ static nfa_state_T *post2nfa(int *postfix, int *end, int nfa_calc_size)
} }
e = POP(); e = POP();
if (stackp != stack) if (stackp != stack) {
EMSG_RET_NULL(_( free(stack);
"E875: (NFA regexp) (While converting from postfix to NFA), too many states left on stack")); EMSG_RET_NULL(_("E875: (NFA regexp) (While converting from postfix to NFA),"
"too many states left on stack"));
}
if (istate >= nstate) if (istate >= nstate) {
EMSG_RET_NULL(_( free(stack);
"E876: (NFA regexp) Not enough space to store the whole NFA ")); EMSG_RET_NULL(_("E876: (NFA regexp) "
"Not enough space to store the whole NFA "));
}
matchstate = &state_ptr[istate++]; /* the match state */ matchstate = &state_ptr[istate++]; /* the match state */
matchstate->c = NFA_MATCH; matchstate->c = NFA_MATCH;