mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2026-08-30 19:11:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(lsp/diagnostic): use diagnostic provider identifier for code actions #38401

Browse Source 
Problem:
f9b2189b28 started using namespaces
for pull diagnostics that look like this `<id>:<identifier>`.
`vim.lsp.buf.codeaction` passes `true` instead of an identifier
to `vim.lsp.diagnostic.get_namespace`, resulting in a namespace that
looks like `<id>:nil`. The end result is that none of the diagnostics are
passed to `textDocument/codeAction` request. Because of that server
might not send any code actions back. For example, eslint lsp responds
with an empty list of actions if it receives no diagnostics.

Solution:
use `_provider_foreach` to collect diagnostics from all `identifiers`
and use that identifier to get a namespace instead of `true`.
This commit is contained in:
Sergei Slipchenko
2026-03-21 17:38:11 +04:00
committed by GitHub
parent 3dbba90ba7
commit 7a5e9ef0aa
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
runtime/lua/vim/lsp/buf.lua
View File

@@ -1365,11 +1365,17 @@ function M.code_action(opts)
params.context = context params.context = context
else else
local ns_push = lsp.diagnostic.get_namespace(client.id, false) local ns_push = lsp.diagnostic.get_namespace(client.id, false)
-- TODO(tris203): should we aggregate diagnostics from all the possible pull namespaces?
local ns_pull = lsp.diagnostic.get_namespace(client.id, true)
local diagnostics = {} local diagnostics = {}
local lnum = api.nvim_win_get_cursor(0)[1] - 1 local lnum = api.nvim_win_get_cursor(0)[1] - 1
vim.list_extend(diagnostics, vim.diagnostic.get(bufnr, { namespace = ns_pull, lnum = lnum }))
client:_provider_foreach('textDocument/diagnostic', function(cap)
local ns_pull = lsp.diagnostic.get_namespace(client.id, cap.identifier)
vim.list_extend(
diagnostics,
vim.diagnostic.get(bufnr, { namespace = ns_pull, lnum = lnum })
)
end)
vim.list_extend(diagnostics, vim.diagnostic.get(bufnr, { namespace = ns_push, lnum = lnum })) vim.list_extend(diagnostics, vim.diagnostic.get(bufnr, { namespace = ns_push, lnum = lnum }))
params.context = vim.tbl_extend('force', context, { params.context = vim.tbl_extend('force', context, {
---@diagnostic disable-next-line: no-unknown ---@diagnostic disable-next-line: no-unknown