mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-09-14 15:28:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix warnings: eval.c: f_rpcrequest(): Garbage value: MI.

Browse Source 
Problem    : Assigned value is garbage or undefined @ 12578.
Diagnostic : Multithreading issue.
Rationale  : Error can only occur if global `provider_call_nesting` is
             changed while function is executing.
Resolution : Use local copy of global.
This commit is contained in:
Eliseo Martínez
2014-11-18 22:20:39 +01:00
parent ee134fc698
commit 7aa7ce253d
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/nvim/eval.c
View File

@@ -12523,6 +12523,7 @@ static void f_rpcrequest(typval_T *argvars, typval_T *rettv)
{ {
rettv->v_type = VAR_NUMBER; rettv->v_type = VAR_NUMBER;
rettv->vval.v_number = 0; rettv->vval.v_number = 0;
const int l_provider_call_nesting = provider_call_nesting;
if (check_restricted() || check_secure()) { if (check_restricted() || check_secure()) {
return; return;
@@ -12550,7 +12551,7 @@ static void f_rpcrequest(typval_T *argvars, typval_T *rettv)
int save_autocmd_fname_full, save_autocmd_bufnr; int save_autocmd_fname_full, save_autocmd_bufnr;
void *save_funccalp; void *save_funccalp;
if (provider_call_nesting) { if (l_provider_call_nesting) {
// If this is called from a provider function, restore the scope // If this is called from a provider function, restore the scope
// information of the caller. // information of the caller.
save_current_SID = current_SID; save_current_SID = current_SID;
@@ -12579,7 +12580,7 @@ static void f_rpcrequest(typval_T *argvars, typval_T *rettv)
args, args,
&err); &err);
if (provider_call_nesting) { if (l_provider_call_nesting) {
current_SID = save_current_SID; current_SID = save_current_SID;
sourcing_name = save_sourcing_name; sourcing_name = save_sourcing_name;
sourcing_lnum = save_sourcing_lnum; sourcing_lnum = save_sourcing_lnum;