mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-09-06 11:28:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

rbuffer: Use xcalloc to ensure memory is initialized

Browse Source 
Since the rbuffer contents are used by string functions (like sscan,
strlen, etc.), it is not safe to use uninitialized memory.  Using
xcalloc ensures the string-based functions do not run past the end of
the buffer.

Closes #5676
This commit is contained in:
James McCoy
2016-11-28 19:30:38 -05:00
parent 39bb43c530
commit 80b808dbfe
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/nvim/rbuffer.c
View File

@@ -18,7 +18,7 @@ RBuffer *rbuffer_new(size_t capacity)
capacity = 0x10000; capacity = 0x10000;
} }
RBuffer *rv = xmalloc(sizeof(RBuffer) + capacity); RBuffer *rv = xcalloc(1, sizeof(RBuffer) + capacity);
rv->full_cb = rv->nonfull_cb = NULL; rv->full_cb = rv->nonfull_cb = NULL;
rv->data = NULL; rv->data = NULL;
rv->size = 0; rv->size = 0;
@@ -78,7 +78,7 @@ void rbuffer_reset(RBuffer *buf) FUNC_ATTR_NONNULL_ALL
size_t temp_size; size_t temp_size;
if ((temp_size = rbuffer_size(buf))) { if ((temp_size = rbuffer_size(buf))) {
if (buf->temp == NULL) { if (buf->temp == NULL) {
buf->temp = xmalloc(rbuffer_capacity(buf)); buf->temp = xcalloc(1, rbuffer_capacity(buf));
} }
rbuffer_read(buf, buf->temp, buf->size); rbuffer_read(buf, buf->temp, buf->size);
} }