mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-09-08 04:18:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

build: move pylint to Makefile, optional with "make lint" (#10714)

Browse Source 
This avoids errors when using "make lint", but "flake8" is not
available.  We do not want to install it then via third-party.
On CI "make pylint" is used explicitly.
This commit is contained in:
Daniel Hahler
2019-08-06 18:53:51 +02:00
committed by GitHub
parent e85b4e749e
commit 8218d474fa
2 changed files with 7 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
CMakeLists.txt
View File

@@ -668,15 +668,6 @@ else()
COMMENT "lualint: LUACHECK_PRG not defined") COMMENT "lualint: LUACHECK_PRG not defined")
endif() endif()
if(FLAKE8_PRG)
add_custom_target(pylint
COMMAND ${FLAKE8_PRG} contrib/ scripts/ src/ test/
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR})
else()
add_custom_target(pylint false
COMMENT "flake8: FLAKE8_PRG not defined")
endif()
set(CPACK_PACKAGE_NAME "Neovim") set(CPACK_PACKAGE_NAME "Neovim")
set(CPACK_PACKAGE_VENDOR "neovim.io") set(CPACK_PACKAGE_VENDOR "neovim.io")
set(CPACK_PACKAGE_VERSION ${NVIM_VERSION_MEDIUM}) set(CPACK_PACKAGE_VERSION ${NVIM_VERSION_MEDIUM})

10
Makefile
View File

@@ -138,8 +138,8 @@ functionaltest-lua: | nvim
lualint: | build/.ran-cmake deps lualint: | build/.ran-cmake deps
$(BUILD_CMD) -C build lualint $(BUILD_CMD) -C build lualint
pylint: | build/.ran-cmake deps pylint:
$(BUILD_CMD) -C build pylint flake8 contrib/ scripts/ src/ test/
unittest: | nvim unittest: | nvim
+$(BUILD_CMD) -C build unittest +$(BUILD_CMD) -C build unittest
@@ -182,7 +182,11 @@ appimage:
appimage-%: appimage-%:
bash scripts/genappimage.sh $* bash scripts/genappimage.sh $*
lint: check-single-includes clint lualint pylint lint: check-single-includes clint lualint
@# Run pylint only if flake8 is installed.
@command -v flake8 \
&& { $(MAKE) pylint; exit $?; } \
|| echo "SKIP: pylint (flake8 not found)"
# Generic pattern rules, allowing for `make build/bin/nvim` etc. # Generic pattern rules, allowing for `make build/bin/nvim` etc.
# Does not work with "Unix Makefiles". # Does not work with "Unix Makefiles".