mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2026-04-23 15:55:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(api): disallow moving window between tabpages in more cases

Browse Source 
Problem: more cases where it may not be safe to move a window between tabpages.

Solution: check them.

Rather speculative... I haven't spend much time looking, but I didn't find
existing code that sets these locks to skip checking win_valid. (what I did find
called it anyway, like in win_close) Still, I think it's a good precaution for
what future code might do.

If the fact that nvim_win_set_config *actually* moves windows between tabpages
causes unforeseen issues, "faking" it like ":wincmd T" may be an alternative:
split a new window, close the old one, but instead also block autocmds, copy the
old window's config, and give it its handle?
This commit is contained in:
Sean Dewar
2026-03-12 17:31:37 +00:00
parent 094b297a3b
commit 853eea859f
3 changed files with 67 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
test/functional/api/window_spec.lua
View File

@@ -3168,7 +3168,6 @@ describe('API/win', function()
)
command('quit!')
-- Can't switch away from window before moving it to a different tabpage during textlock.
exec(([[
new
call setline(1, 'foo')
@@ -3180,6 +3179,41 @@ describe('API/win', function()
pcall_err(command, 'normal! ==')
)
eq(cur_win, api.nvim_get_current_win())
exec(([[
wincmd p
call setline(1, 'bar')
setlocal indentexpr=nvim_win_set_config(win_getid(winnr('#')),#{split:'left',win:%d})
]]):format(t2_win))
neq(cur_win, api.nvim_get_current_win())
matches(
'E565: Not allowed to change text or change window$',
pcall_err(command, 'normal! ==')
)
-- expr_map_lock
exec(([[
nnoremap <expr> @ nvim_win_set_config(win_getid(winnr('#')),#{split:'left',win:%d})
]]):format(t2_win))
neq(cur_win, api.nvim_get_current_win())
matches(
'E565: Not allowed to change text or change window$',
pcall_err(fn.feedkeys, '@', 'x')
)
exec(([[
wincmd p
autocmd WinNewPre * ++once call nvim_win_set_config(0, #{relative:'editor', win:%d, row:0, col:0, width:1, height:1})
]]):format(t2_win))
matches(
'E1312: Not allowed to change the window layout in this autocmd$',
pcall_err(command, 'split')
)
eq(cur_win, api.nvim_get_current_win()) -- :split didn't enter new window due to error
exec(([[
autocmd WinLeave * ++once call nvim_win_set_config(0, #{relative:'editor', win:%d, row:0, col:0, width:1, height:1})
]]):format(t2_win))
matches('Cannot move window to another tabpage whilst in use$', pcall_err(command, 'quit'))
eq(cur_win, api.nvim_get_current_win()) -- :quit didn't close window due to error
end)
it('updates statusline when moving bottom split', function()