mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-10-26 12:27:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(highlight): update PmenuSel for colored completion items #30183

Browse Source 
Problem: completion items can now have dedicated highlighting (through
  `hl_group` and `kind_hlgroup` fields). Both of the fields combine
  their highlight attributes with the underlying `PmenuXxx` group.

  As default color scheme `Pmenu` and `PmenuSel` are intentionally
  almost inverted versions of one another, the added highlighting will
  be unreadable in one of them if done only through foreground (which is
  the most convenient way for users and being able to do so is arguably
  the biggest benefit of actually combining added highlighting).

Solution: adjust `PmenuSel` to utilize `attr=reverse`. This works
  because `fg`/`bg` are first combined and only then reversed. This
  results in a colored background for items with `hl_group` and
  `kind_hlgroup` using text highlighting.

  This also results in the same background for regular selected item,
  while intentionally changing foreground from `Nvim{Light,Dark}Grey3`
  to (essentially) `Nvim{Light,Dark}Grey2`. This both provides better
  contrast ratio and does not need realigning of the whole block.
This commit is contained in:
Evgeni Chasnovski
2024-08-29 22:08:30 +03:00
committed by GitHub
parent 9a3c8f64a7
commit 862679c70f
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/nvim/highlight_group.c
View File

@@ -144,6 +144,7 @@ static const char e_missing_argument_str[]
static const char *highlight_init_both[] = { static const char *highlight_init_both[] = {
"Cursor guifg=bg guibg=fg", "Cursor guifg=bg guibg=fg",
"CursorLineNr gui=bold cterm=bold", "CursorLineNr gui=bold cterm=bold",
"PmenuSel gui=reverse cterm=reverse,underline blend=0",
"RedrawDebugNormal gui=reverse cterm=reverse", "RedrawDebugNormal gui=reverse cterm=reverse",
"TabLineSel gui=bold cterm=bold", "TabLineSel gui=bold cterm=bold",
"TermCursor gui=reverse cterm=reverse", "TermCursor gui=reverse cterm=reverse",
@@ -358,7 +359,6 @@ static const char *highlight_init_light[] = {
"NonText guifg=NvimLightGrey4", "NonText guifg=NvimLightGrey4",
"NormalFloat guibg=NvimLightGrey1", "NormalFloat guibg=NvimLightGrey1",
"Pmenu guibg=NvimLightGrey3 cterm=reverse", "Pmenu guibg=NvimLightGrey3 cterm=reverse",
"PmenuSel guifg=NvimLightGrey3 guibg=NvimDarkGrey2 cterm=reverse,underline blend=0",
"PmenuThumb guibg=NvimLightGrey4", "PmenuThumb guibg=NvimLightGrey4",
"Question guifg=NvimDarkCyan ctermfg=6", "Question guifg=NvimDarkCyan ctermfg=6",
"QuickFixLine guifg=NvimDarkCyan ctermfg=6", "QuickFixLine guifg=NvimDarkCyan ctermfg=6",
@@ -443,7 +443,6 @@ static const char *highlight_init_dark[] = {
"NonText guifg=NvimDarkGrey4", "NonText guifg=NvimDarkGrey4",
"NormalFloat guibg=NvimDarkGrey1", "NormalFloat guibg=NvimDarkGrey1",
"Pmenu guibg=NvimDarkGrey3 cterm=reverse", "Pmenu guibg=NvimDarkGrey3 cterm=reverse",
"PmenuSel guifg=NvimDarkGrey3 guibg=NvimLightGrey2 cterm=reverse,underline blend=0",
"PmenuThumb guibg=NvimDarkGrey4", "PmenuThumb guibg=NvimDarkGrey4",
"Question guifg=NvimLightCyan ctermfg=14", "Question guifg=NvimLightCyan ctermfg=14",
"QuickFixLine guifg=NvimLightCyan ctermfg=14", "QuickFixLine guifg=NvimLightCyan ctermfg=14",