From 88d8ca73f9d1e49342a0d93763606af1e38e0461 Mon Sep 17 00:00:00 2001 From: Thiago de Arruda Date: Sat, 28 Mar 2015 12:29:47 -0300 Subject: [PATCH] eval: Improve validation of ids passed to job functions Use the `is_user_job` to ensure that the job was started by `jobstart` or `termopen`. --- src/nvim/eval.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/nvim/eval.c b/src/nvim/eval.c index 4baca21116..3b1b034b33 100644 --- a/src/nvim/eval.c +++ b/src/nvim/eval.c @@ -10721,7 +10721,7 @@ static void f_jobsend(typval_T *argvars, typval_T *rettv) Job *job = job_find(argvars[0].vval.v_number); - if (!job) { + if (!is_user_job(job)) { // Invalid job id EMSG(_(e_invjob)); return; @@ -10763,7 +10763,7 @@ static void f_jobresize(typval_T *argvars, typval_T *rettv) Job *job = job_find(argvars[0].vval.v_number); - if (!job) { + if (!is_user_job(job)) { // Probably an invalid job id EMSG(_(e_invjob)); return; @@ -10883,8 +10883,7 @@ static void f_jobstop(typval_T *argvars, typval_T *rettv) Job *job = job_find(argvars[0].vval.v_number); - if (!job) { - // Probably an invalid job id + if (!is_user_job(job)) { EMSG(_(e_invjob)); return; }