From 8f0b94b36d4d6687712ccfc525284f1fac58d2f6 Mon Sep 17 00:00:00 2001 From: Wei Tang Date: Tue, 11 Oct 2022 08:46:34 +0800 Subject: [PATCH] build(deps): disable shared library for libvterm. (#20566) build(deps): disable shared library for libvterm Problem: Cannot build both static and share libraries for libvterm under Windows. The static and shared library would have the same name "vterm.lib", thus there would be multiple rules to build the same target. Solution: Disable shared library for libvterm. This makes it possible to use Ninja on Windows to build dependencies (2x speedup!). But not for Release builds yet. Co-authored-by: Wei Tang --- cmake.deps/cmake/LibvtermCMakeLists.txt | 8 -------- 1 file changed, 8 deletions(-) diff --git a/cmake.deps/cmake/LibvtermCMakeLists.txt b/cmake.deps/cmake/LibvtermCMakeLists.txt index ff1d2d6b79..d7ec9eacad 100644 --- a/cmake.deps/cmake/LibvtermCMakeLists.txt +++ b/cmake.deps/cmake/LibvtermCMakeLists.txt @@ -41,14 +41,6 @@ file(GLOB VTERM_SOURCES ${CMAKE_SOURCE_DIR}/src/*.c) add_library(vterm ${VTERM_SOURCES} ${TBL_FILES_HEADERS}) install(TARGETS vterm ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}) -add_library(vterm-shared SHARED ${VTERM_SOURCES} ${TBL_FILES_HEADERS}) -set_target_properties(vterm-shared PROPERTIES - OUTPUT_NAME vterm - SOVERSION 0) -install(TARGETS vterm-shared - LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR} - RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}) - install(FILES include/vterm.h include/vterm_keycodes.h DESTINATION include)