mirrors/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-12-06 06:32:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

lsp: Reduce memory usage for buffering the message from LSP.

Browse Source
This commit is contained in:
Yuki Ito
2020-10-19 19:56:56 +09:00
parent a35c54b2ae
commit 900228a20f
1 changed files with 20 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
runtime/lua/vim/lsp/rpc.lua
View File

@@ -139,7 +139,7 @@ local header_start_pattern = ("content"):gsub("%w", function(c) return "["..c..c
--@private --@private
--- The actual workhorse. --- The actual workhorse.
local function request_parser_loop() local function request_parser_loop()
local buffer = '' local buffer = '' -- only for header part
while true do while true do
-- A message can only be complete if it has a double CRLF and also the full -- A message can only be complete if it has a double CRLF and also the full
-- payload, so first let's check for the CRLFs -- payload, so first let's check for the CRLFs
@@ -154,17 +154,29 @@ local function request_parser_loop()
-- TODO(ashkan) I'd like to remove this, but it seems permanent :( -- TODO(ashkan) I'd like to remove this, but it seems permanent :(
local buffer_start = buffer:find(header_start_pattern) local buffer_start = buffer:find(header_start_pattern)
local headers = parse_headers(buffer:sub(buffer_start, start-1)) local headers = parse_headers(buffer:sub(buffer_start, start-1))
buffer = buffer:sub(finish+1)
local content_length = headers.content_length local content_length = headers.content_length
-- Use table instead of just string to buffer the message. It prevents
-- a ton of strings allocating.
-- ref. http://www.lua.org/pil/11.6.html
local body_chunks = {buffer:sub(finish+1)}
local body_length = #body_chunks[1]
-- Keep waiting for data until we have enough. -- Keep waiting for data until we have enough.
while #buffer < content_length do while body_length < content_length do
buffer = buffer..(coroutine.yield() local chunk = coroutine.yield()
or error("Expected more data for the body. The server may have died.")) -- TODO hmm. or error("Expected more data for the body. The server may have died.") -- TODO hmm.
table.insert(body_chunks, chunk)
body_length = body_length + #chunk
end end
local body = buffer:sub(1, content_length) local last_chunk = body_chunks[#body_chunks]
buffer = buffer:sub(content_length + 1)
body_chunks[#body_chunks] = last_chunk:sub(1, content_length - body_length - 1)
local rest = ''
if body_length > content_length then
rest = last_chunk:sub(content_length - body_length)
end
local body = table.concat(body_chunks)
-- Yield our data. -- Yield our data.
buffer = buffer..(coroutine.yield(headers, body) buffer = rest..(coroutine.yield(headers, body)
or error("Expected more data for the body. The server may have died.")) -- TODO hmm. or error("Expected more data for the body. The server may have died.")) -- TODO hmm.
else else
-- Get more data since we don't have enough. -- Get more data since we don't have enough.